Repository navigation
JS-Escape literal text in templates - #72
Open
CGamesPlay wants to merge 1 commit into
Open
CGamesPlay wants to merge 1 commit into
CGamesPlay wants to merge 1 commit into
Conversation
- Including curly brackets in string interpolation should be possible. - Including a double quote in a template should not result in a syntax error.
Author
|
My previous commit didn't pay attention and broke string interpolation. Here, I've gone and fixed it, including the nesting curly brackets part. |
Author
|
@petermelias may be interested in this |
|
@CGamesPlay thanks for the consideration. I ended up ditching this library in favor of the native compiler because there turned out to just be too many little things that worked differently. Whitespace and line-break parsing etc... but yeah this is definitely helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including a double quote in a template should not result in a syntax error.