Fixed graphics bug for Graphics test - #170
Open
connorclancydev wants to merge 1 commit into
Open
Conversation
Fixed an error where when the text font cache wouldn't be cleared when windows were destroyed causing issues when other windows would open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an error where the text font cache wouldn't be cleared when windows were destroyed causing graphical issues when other windows would open
Description
Msys2 has been having issues with the graphics test whilst WSL has been fine, this change is to fix that it is done by clearing out the global font data when a window is shut so its settings wont cause issues when a new window is opened up. Note to test if you are using Msys2 you may need to implement this PR(#132) to be able to test it as there have been issues, this info is also on the ticket.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
To test this I opened opened up the sktests and tested the graphics about thirty times, thirty might be excessive but it is important to not that I found this error that was fixed almost never appeared on the first run and would often not appear on the second so it is important to test it at least a few times. Additionally I ran the skunit_tests to make sure nothing in there got broken with this fix.
Testing Checklist
Checklist