Repository navigation
ci: keep the pipeline run report and cache Playwright browsers - #7813
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
ReviewSmall, focused CI change. It looks correct and consistent with the repo's existing conventions: Observations (none blocking):
Upload step: LGTM overall. |
[Low impact] The PR appears safe to merge. SummaryThis PR adds browser caching and preserves pipeline diagnostics in the .NET workflow.
No confirmed actionable issues were found. Reviews (1) · Last reviewed commit: "ci: keep the pipeline run report and cac..." · Reviewed by Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4962670ddd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks. Going through these:
|
The pipeline already writes
artifacts/run-report.json(module timings, CPU/memory saturation periods) but nothing uploaded it, so it was lost with the runner. This uploads it per OS asPipelineRunReport-<os>.Also caches
.modularpipelines/run-historyso the results table gets its "Δ previous" column, and caches the Playwright browsers keyed on theMicrosoft.Playwrightversion.Why Playwright: on run 44271268223
InstallPlaywrightModulefinished last on Ubuntu (5m 37s) and Windows (4m 22s). Windows sat ~2 min waiting on it after every other module was done.Notes:
--with-depsstill runs apt each time, only the browser download is cached, so Ubuntu will gain less than Windows.Summary by CodeRabbit