Skip to content

ci: keep the pipeline run report and cache Playwright browsers - #7813

Merged
thomhurst merged 1 commit into
mainfrom
ci/pipeline-run-report-and-playwright-cache
Nov 18, 2026
Merged

thomhurst merged 1 commit into
mainfrom
ci/pipeline-run-report-and-playwright-cache

Conversation

@thomhurst

@thomhurst thomhurst commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

The pipeline already writes artifacts/run-report.json (module timings, CPU/memory saturation periods) but nothing uploaded it, so it was lost with the runner. This uploads it per OS as PipelineRunReport-<os>.

Also caches .modularpipelines/run-history so the results table gets its "Δ previous" column, and caches the Playwright browsers keyed on the Microsoft.Playwright version.

Why Playwright: on run 44271268223 InstallPlaywrightModule finished last on Ubuntu (5m 37s) and Windows (4m 22s). Windows sat ~2 min waiting on it after every other module was done.

Notes:

  • On Linux --with-deps still runs apt each time, only the browser download is cached, so Ubuntu will gain less than Windows.
  • dotnet.yml only runs on PRs and manual dispatch, so a PR gets a cache hit from its second push, or from main after a manual run.

Summary by CodeRabbit

  • Improvements
    • Playwright browser downloads are cached by operating system and package version to speed up subsequent pipeline runs.
    • Pipeline run history is restored from compatible prior runs and saved for future runs.
    • A run report is uploaded as an artifact whenever available, including when the pipeline fails.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T12:52:20.393495Z 4962670 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The modularpipeline job adds Playwright browser and pipeline run-history caching. It also uploads artifacts/run-report.json as an artifact on every outcome, while ignoring a missing report.

Changes: Pipeline job updates

Layer / File(s) Summary
Pipeline cache setup
.github/workflows/dotnet.yml
The job caches Playwright browser directories by runner OS and package version. It restores run history with a run-specific key and a shared OS-and-job restore prefix.
Run report upload
.github/workflows/dotnet.yml
The job always uploads artifacts/run-report.json as an artifact named by runner OS. It ignores a missing report.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 49626

This change only adds CI caching and a run-report artifact upload. Its worst realistic outcome is a cache or report that does not take effect, which would not affect shipped code. No blocking issues were found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: keep the pipeline run report and cache Playwright browsers" matches the main changes. The workflow now uploads artifacts/run-report.json on every outcome, restores per-OS pipeline run h…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: keep the pipeline run report and cache Playwright browsers" matches the main changes. The workflow now uploads artifacts/run-report.json on every outcome, restores per-OS pipeline run history, and caches Playwright browsers keyed by the Playwright package version. The title names both main aspects of the change in a short, specific sentence.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the cache at dawn,
Browser paths are tucked away.
Run history waits, restored and neat,
Reports hop up when jobs complete,
Even if one file is gone.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38c21f12-f4b5-4b11-9734-f078c9d78b41
Commits

Reviewing files that changed from the base of the PR and between 4823ace and 4962670.

Files selected for processing: 1

  • .github/workflows/dotnet.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

Review

Small, focused CI change. It looks correct and consistent with the repo's existing conventions: actions/cache@v6 and upload-artifact@v7.0.2 are already used elsewhere, and the Playwright version regex matches Directory.Packages.props (1.65.0).

Observations (none blocking):

  1. Run-history cache growth/eviction. Each run saves a unique key (...-run_id-run_attempt), so every PR run adds a new cache entry. With the 10GB repo cap this churns LRU eviction and may evict the Playwright and NuGet caches. Check the run-history directory is small. If it isn't, restrict saving to main/manual runs, or prune the directory before the post-step save.
  2. Cache scoping. PR caches are only readable from the same PR or the base branch. That is acceptable for the "Δ previous" column, but the history will be per-PR, so deltas are only meaningful from the second push. This matches your PR notes.
  3. Playwright cache on Linux. As you noted, --with-deps still runs apt. If the dominant cost is apt, the gain will be small. Splitting deps and browser install could help, but that's a follow-up.
  4. Version extraction. If the Microsoft.Playwright line moves or the version becomes a property, sed yields an empty string. The key then degrades to playwright-Linux- and could go stale silently. Consider failing the step when the output is empty.
  5. github.job in the key. It's the job id and not the matrix entry, but runner.os already differentiates the matrix. Fine as long as one OS maps to one matrix entry.

Upload step: if: always() with if-no-files-found: ignore is the right combination.

LGTM overall.

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

This PR adds browser caching and preserves pipeline diagnostics in the .NET workflow.

  • Runs can reuse Playwright browsers when the OS and package version match.
  • Pipeline results can compare module timings with earlier runs.
  • Each pipeline run saves its report as an OS-named artifact.

No confirmed actionable issues were found.

Reviews (1) · Last reviewed commit: "ci: keep the pipeline run report and cac..." · Reviewed by Greptile

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4962670ddd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/dotnet.yml Resolved
@thomhurst

Copy link
Copy Markdown
Owner Author

Thanks. Going through these:

  1. History entries are tiny, just JSON reports with the 20-report retention, so a few KB each. Shouldn't move the needle on eviction.
  2. Yep, expected.
  3. Agreed, follow-up if the numbers show apt dominates.
  4. Leaving it. An empty version just means a key that never matches the right browsers, so Playwright downloads like it does today. No worse than now.
  5. Right, one matrix entry per OS.

@thomhurst
thomhurst enabled auto-merge (squash) November 18, 2026 12:57
@thomhurst
thomhurst merged commit b2927b9 into main Nov 18, 2026
31 checks passed
@thomhurst
thomhurst deleted the ci/pipeline-run-report-and-playwright-cache branch November 18, 2026 13:06
This was referenced Nov 20, 2026

This branch was previously deployed

1 inactive deployment
Pull Requests — 4962670d Deployed Nov 18, 2026 by thomhurst via modularpipeline (macos-latest) #21759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant