Repository navigation
Raise data-source delegates at test lifecycle stages - #7521
Conversation
|
@codex review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Review: Raise data-source delegates at test lifecycle stagesI read the diff. The Claude review skill failed to run, so this was a manual read and I did not run any tests. What looks right
Suggestions (non-blocking)
Overall this is a clean change with good test coverage. CI on the engine tests will be the real check. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f885cfc79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
[Medium impact] The PR appears safe to merge; the previous cancellation issue is fixed. SummaryRaises data-source delegates at registration, start, end, skip, and retry stages.
Reviews (2) · Last reviewed commit: "Stop retrying after successful handlers ..." · Reviewed by Greptile |
|
Addressed both retry-cancellation findings in 8ea91bd. The regression failed before the fix and all 3 retry-delegate cancellation cases now pass in generated and reflection modes (net10.0). Engine.Tests remains for CI per repository instructions. Claude's nonblocking suggestions: keeping the small dispatch loops explicit preserves their different propagation/teardown collection semantics; keeping the orchestrator's existing await convention avoids unrelated style changes. I checked registration exception propagation: the existing receiver path can abort the whole request, so I recorded that separate engine failure-isolation problem as #7525. It does not block this lifecycle dispatch change. |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Review of #7521I read the diff and the retry loop in Overall: The change looks correct and the scope is tight. It dispatches the start, end, skipped, registration and retry delegate events that were previously stored but never raised. What I checked
Suggestions (non-blocking)
No blocking issues. Engine tests are left to CI as per repo policy. |
|
Reviewed all review bodies, inline threads and conversation comments for 8ea91bd. Claude and Codex both report no blocking findings; both cancellation threads have pushed fixes and are resolved. Disposition of Claude's latest nonblocking suggestions: retain the explicit loops because the end path collects failures while the other paths propagate them; a shared helper can be considered separately. Keep Marking ready to start hosted CI. Auto-merge must wait for the Claude review triggered by promotion to complete successfully; a later unit will read that review and arm it. |
ReviewThe PR wires up the delegate subscriptions ( What looks right
Suggestions, non-blocking
Tests cover generated and reflection modes, retry, skip, class-level data and property injection. Nice work. |
|
The earlier blocker is cleared: Claude run 41711875402 succeeded for 8ea91bd. I re-read the review bodies, inline comments, resolved threads and conversation comments. Claude and Codex both have positive verdicts on this head, and no reviewer has reopened the cancellation findings after their fixes. Disposition of the promotion review's nonblocking suggestions: retain explicit dispatch loops to keep propagation and teardown collection visible, and retain the existing orchestrator await convention. The registration second-pass guard intentionally avoids dispatch after the skip path; existing property-injection and skip tests cover that behavior, so an extra comment is optional. Earlier dispositions still apply; no new blocking findings remain. The final merge gate passed: CLEAN, all 39 checks green, no unresolved threads. Merging this reviewed head. |
Data-source subscriptions to registration, start, end, skipped and retry events were retained in row contexts but never dispatched. Raise them alongside the matching lifecycle receivers, with start/end delegates in the late stage and retry delegates receiving the upcoming one-based attempt after backoff and cancellation checks.
Registration tracks subscription identity across the pre/post property-injection passes, preserving duplicate subscriptions. Dispatch uses AsyncEvent's immutable published list as a snapshot. End failures join the teardown exception collection; other event failures propagate, and failing retry handlers preserve accepted cancellation. Reuses the merged ownership/context foundation from #7472 without changing scope ownership or shipped signatures.
Closes #7473
Validation: