Repository navigation
fix(sourcegen): bind params T[] on generic test methods #7101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6c9c5d1
fix(sourcegen): bind params T[] on generic test methods
thomhurst a2f33f5
fix: address review findings for generic params T[] binding
thomhurst f47e6e0
fix(engine): use declared defaults for omitted optional args in refle…
thomhurst e594a6f
fix: address review on generic params inference and named trailing ar…
thomhurst 10d6132
test: refresh Tests7099 snapshot line numbers
thomhurst 50737ef
fix: bind arrays before a trailing token and keep omitted optional ar…
thomhurst 5a47330
fix: pass omitted optional arrays as typed null and skip tokens in ge…
thomhurst 55a1e58
fix: keep a leading CancellationToken in place for generic trailing-a…
thomhurst e5a90af
fix: keep a generic data parameter closed over CancellationToken in t…
thomhurst 58ffac4
fix(engine): skip a leading CancellationToken when inferring generic …
thomhurst 87d4de1
fix(sourcegen): pass every CancellationToken on generic trailing-arra…
thomhurst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.