Skip to content

Merge guidance omits required AOT and Engine checks #7444

Closed

Description

@thomhurst

Summary

The issue/PR loop's repository guidance lists only two required CI checks for main, while GitHub currently requires eight. Update the guidance so agents assessing merges have an accurate account of the branch protection.

Reproduction

Read .agents/skills/issue-pr-loop/references/repository.md, Merge gate, on main at d8badac. Compare its two-check list against gh api repos/thomhurst/TUnit/branches/main/protection.

Expected and actual

The guide should describe the current required checks, or point to the live protection API as authoritative. The API currently requires modularpipeline on Ubuntu/macOS, Engine tests on Ubuntu/Windows/macOS, and AOT on Ubuntu/Windows/macOS; the guide lists only modularpipeline on Ubuntu/macOS. The merge wrapper still checks all checks, so this documentation mismatch did not bypass validation for #7406.

Please align the merge guidance with the live protection configuration.

Activity

  1. added
    documentationImprovements or additions to documentation
    P3Low: cleanup, minor enhancement, or rare edge case
    on Nov 3, 2026
  2. thomhurst commented on Nov 3, 2026

    @thomhurst
    OwnerAuthor

    Triage confirmed this remains actionable: fresh origin/main still lists only the two modularpipeline checks, while the live main protection API requires those plus Engine tests and AOT on Ubuntu, Windows, and macOS (eight checks total). No linked closing PR, parent, sub-issue, or blocker was found. The existing scope remains current.

  3. thomhurst commented on Nov 5, 2026

    @thomhurst
    OwnerAuthor

    Already implemented on origin/main. Commit b590241 (PR #7544) added the missing Engine tests and AOT checks to the merge guidance. Commit bbab999 (PR #7578) subsequently updated it for the removal of separate macOS AOT and Engine requirements.

    Verified against the live branches/main/protection API today: the six required contexts are modularpipeline (ubuntu-latest), modularpipeline (macos-latest), Engine tests (ubuntu-latest), Engine tests (windows-latest), AOT (ubuntu-latest), and AOT (windows-latest). The Merge gate section lists all six accurately. No further implementation is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low: cleanup, minor enhancement, or rare edge casedocumentationImprovements or additions to documentation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions