Repository navigation
Capture child-only JIT listings in frozen native replay - #694
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
@codex review |
|
Review of #694: no blocking issues found.
Minor, non-blocking: the listing check only looks for the |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Current-head review disposition: Claude CLEAR and Codex completed without findings both cover 6179915. Claude’s minor listing-header observation is non-blocking: the capture intentionally establishes that a listing exists; the PR documents completeness limits. No code change is needed. Reverified all 32 archived validation files against their lengths and SHA-256 inventory, and verified the manifest hash recorded in the PR body. The durable location remains |
The frozen native-parent launcher can replay original scoped dispatch images but cannot capture their compiled code without instrumenting the parent too. Add opt-in
--jit-method/ workflowjit_methodusing .NET's native JIT disassembly settings, with distinct child-only output per launch. Capture failures retain every outcome and fail visibly. Diagnostic measurements live underdiagnosticResultsand are explicitly excluded from timing/allocation evidence; default uninstrumented output is unchanged.Reuses native
DOTNET_JitDisasm,DOTNET_JitDisasmDiffable,DOTNET_JitStdOutFile, BenchmarkDotNet's existing native parent, the existing shell-quoted child environment wrapper, frozen inventories, selected-runner receipt validation and result parser. No native capability is duplicated. Missing/inlined/precompiled/interleaved code and unobserved tiers remain limitations: this does not reconstruct historical execution or prove equivalence.Validation: all 25
test_frozen_bdn_control.pytests pass, including parent/child isolation, real shell quoting, mixed-mode rejection and preservation of all four launches after failed capture/processes. A small local .NET 10.0.14 ARM64 smoke fixture emitted a valid native JIT listing and printed 42. This validates runtime diagnostic support only; the original Linux x64 capture has not run. No benchmark or production tests required.Validation sources, binaries and logs retained at
/Users/tom/git/Relayer-evidence/pr-694/6179915c70bd98996612e37d0c4a01c55c5d562f/while PR #694 remains open; all 32 files independently read-back hash/length verified againstvalidation-sha256.json(SHA-2563f09113c1ac012b91f92286f44a08fbd1e0e3d7828162753949263a395064ae6).Per-message cost: unchanged, 0 B; internal investigation tooling only. No docs impact.
Closes #692
Next diagnostic for #613; does not close its historical throughput investigation. After this reaches trusted main, capture one native-parent scoped-dispatch ABBA with original run 43409168876, runtime 10.0.15 and method filter
*DirectScopedDispatch*; preserve all raw listings/receipts/outcomes and compare observed code/tiers before choosing further work. Exclude instrumented timings and allocations.