Repository navigation
test: remove sender allocation test parallelism throttles - #597
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
@codex review |
|
Reviewed the head of PR 597. It looks sound.
One non-blocking note. The warmup relies on reflection into private runtime internals ( |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The earlier Codex wait is resolved: its mutable summary now records completed review with no findings for c94c248, matching Claude CLEAR run 43393735035/1. All review surfaces were checked; no outstanding findings or threads. Verified the inventory and SHA-256 manifest for all five retained evidence files at /Users/tom/git/Relayer-evidence/pr-597/c94c248dcaa6ddc3cace489e9957f0f668c5bac3/. The original worktree has been cleaned; the prior unit recorded verified copying from the originals, and this unit verified the retained files against that manifest. No tests rerun because the code is unchanged. Promoted and armed auto-merge using scripts/Enable-AutoMerge.ps1 -Pr 597 -MarkReady. Head is unchanged; ready CI run 43394132910 is queued. GitHub will merge after required checks pass. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The direct-send and overlapping-send allocation checks now warm native timer-queue lock contention during setup, using
TimerQueueWarmupfrom #587. Removing both[NotInParallel]attributes lets these thread-local measurements run alongside other tests while retaining exact zero-byte assertions and finite native send deadlines.Closes #588
Validation: focused sender allocation tests passed on net10.0 and net11.0 (3 cases each, 6 total). Full diff reviewed for reuse, correctness, and performance. Evidence:
/Users/tom/git/Relayer-evidence/pr-597/c94c248dcaa6ddc3cace489e9957f0f668c5bac3/(log and test reports, copied with verified SHA-256 manifest).Native/existing features: reuses .NET timer queues and the existing test-only
TimerQueueWarmup.WarmContention; no replacement timer or synchronization implementation.Per-message cost: unchanged, 0 B added; only test setup changes. No benchmark required. No docs impact: no production or user-facing behavior changes.