Skip to content

test: remove sender allocation test parallelism throttles - #597

Merged
thomhurst merged 1 commit into
mainfrom
issue-588-sender-timer
Nov 13, 2026
Merged

thomhurst merged 1 commit into
mainfrom
issue-588-sender-timer

Conversation

@thomhurst

@thomhurst thomhurst commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

The direct-send and overlapping-send allocation checks now warm native timer-queue lock contention during setup, using TimerQueueWarmup from #587. Removing both [NotInParallel] attributes lets these thread-local measurements run alongside other tests while retaining exact zero-byte assertions and finite native send deadlines.

Closes #588

Validation: focused sender allocation tests passed on net10.0 and net11.0 (3 cases each, 6 total). Full diff reviewed for reuse, correctness, and performance. Evidence: /Users/tom/git/Relayer-evidence/pr-597/c94c248dcaa6ddc3cace489e9957f0f668c5bac3/ (log and test reports, copied with verified SHA-256 manifest).

Native/existing features: reuses .NET timer queues and the existing test-only TimerQueueWarmup.WarmContention; no replacement timer or synchronization implementation.

Per-message cost: unchanged, 0 B added; only test setup changes. No benchmark required. No docs impact: no production or user-facing behavior changes.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe0fd87c-fab9-4575-8940-e6b96ce656ce
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thomhurst

Copy link
Copy Markdown
Owner Author

@codex review

@github-actions

Copy link
Copy Markdown

Reviewed the head of PR 597. It looks sound.

  • Both [NotInParallel] attributes are removed. That matches AGENTS.md, which forbids concurrency throttles on these tests.
  • TimerQueueWarmup.WarmContention() runs after the warmup loops and before GC.GetAllocatedBytesForCurrentThread() is read. Its thread creation and lock allocations therefore stay outside the measured window.
  • The warmup initializes the lazy wait state of each shared TimerQueue lock once. That state is the source of the contention allocations, so later parallel contention should not allocate again. The exact IsEqualTo(0L) assertions are kept.
  • The warmup is test-only and does not replace any native timer, so no production code, benchmark or docs change is needed.
  • The helper fails loudly on an unsupported runtime and times out after 10s, so it should not hang.
  • I did not run any tests.

One non-blocking note. The warmup relies on reflection into private runtime internals (TimerQueue.Instances and SharedLock). It throws a clear message if they move, and that is acceptable for test-only code.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T08:34:37.989250Z c94c248 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@thomhurst

thomhurst commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner Author

The earlier Codex wait is resolved: its mutable summary now records completed review with no findings for c94c248, matching Claude CLEAR run 43393735035/1. All review surfaces were checked; no outstanding findings or threads. Verified the inventory and SHA-256 manifest for all five retained evidence files at /Users/tom/git/Relayer-evidence/pr-597/c94c248dcaa6ddc3cace489e9957f0f668c5bac3/. The original worktree has been cleaned; the prior unit recorded verified copying from the originals, and this unit verified the retained files against that manifest. No tests rerun because the code is unchanged.

Promoted and armed auto-merge using scripts/Enable-AutoMerge.ps1 -Pr 597 -MarkReady. Head is unchanged; ready CI run 43394132910 is queued. GitHub will merge after required checks pass.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: c94c248dca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thomhurst
thomhurst marked this pull request as ready for review November 13, 2026 08:33
@thomhurst
thomhurst enabled auto-merge (squash) November 13, 2026 08:33
@thomhurst
thomhurst merged commit c9cfc7f into main Nov 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove timer-contention throttles from send allocation tests

1 participant