Repository navigation
fix: initialize inbox test model before concurrent database work - #571
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review of #571: no blocking findings.
I did not run the tests. The PR reports 55 InboxTests passing on net10.0 and net11.0. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Both required reviews clear current head d179ca1; no review threads or blocking findings remain. Claude’s optional follow-up suggestion is non-blocking and declined: the removal trigger is already recorded beside the workaround, so no additional code or tracking issue is needed. Validation evidence was rehashed against its original inventory and copied to |
Pull request was converted to draft
Review of #571Blocking: the PR contains unrelated, undisclosed changes. The title and description cover only the PostgreSQL
The description does not mention any of this. It says 'test initialization only' and 'No docs impact', which is inaccurate for a new CI workflow that uploads Why this matters:
Suggestion: split this into two PRs. Keep only The InboxTests change itself looks sound.
|
|
@codex review The earlier waiting blocker has ended: ready CI run 43383708766 failed the unrelated batch allocation comparison (+56 B on net10.0); InboxTests and net11.0 passed. Commit b3b0e29 adds a bounded hosted exact-callback investigation using the existing profiler, without relaxing the assertion, rerunning CI for green, or claiming the failure is fixed. Local focused comparison passes 4/4 across both targets. The PR is back in draft for new-head review. Hosted diagnostic: https://github.com/thomhurst/Relayer/actions/runs/43386487904 . It records eight fixed original/callback process pairs, all outcomes and executable inputs; callback results are separate instrumented observations, not attribution of the historical +56 B window. Inspect that run and both current-head reviews next. The PR body records validation and evidence retention. No linked prerequisite, superseding implementation or finished parent removes this CI failure; no duplicate #299/#348 workaround was added. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…allbacks" This reverts commit b3b0e29.
|
Disposition of Claude’s review: separation of the completed diagnostic from the inbox fix is accepted and addressed in 573afcd. This PR now changes only The historical ready CI run 43383708766 is terminal failed, so the old waiting blocker has ended. Its unrelated +56 B allocation failure remains unexplained in #585; no failure is suppressed or called fixed. The bounded investigation captured all sixteen passing original/callback process outcomes, but those cannot attribute the failing historical window. The original failure log, diagnostic sources and all 2,010 hash-verified hosted-manifest files are retained independently under #585’s evidence root and the uploaded artifact. #299/#348’s +40 B mechanism does not establish this cause. No CI rerun was requested. Validation for this removal: focused batch comparison 4/4 passed on net10.0/net11.0; @codex review |
|
Reviewed the head of #571 (test-only change in
No actionable findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
The earlier wait on run 43383708766 has ended. Its failed allocation comparison was investigated in the subsequent bounded diagnostic and remains explicitly tracked in #585; no rerun or relaxed assertion is requested here. Current head 573afcd contains only InboxTests.cs and both required reviewers clear that exact head. All review surfaces were inspected; no threads or undispositioned findings remain. There is no prerequisite dependency, superseding PR or finished parent that requires a different resolution route. Reverified retained validation inventories: all 484 files under /Users/tom/git/Relayer-evidence/pr-571/573afcd-validation/ and all 588 files under /Users/tom/git/Relayer-evidence/pr-571/d179ca1f7b2f7f934ea032ba83508152852dccdf/ match their recorded lengths and SHA-256 hashes. Prior independent original-to-archive comparisons are recorded above. Code is unchanged, so no local tests were repeated. Promoting the reviewed head for fresh required CI through the protected wrapper. |
PostgreSQL InboxTests can race the first native EF relational-model initialization, throwing
ModelNotFinalizedbefore settlement-disposal assertions run. Add a test-context model-finalized convention that calls nativeGetRelationalModelduring EF's existing model-construction pipeline, before the runtime model is published. Tests remain parallel; no new lock or global state is introduced.Closes #570
Native/existing reuse: EF 10.0.15's
ConfigureConventions,IModelFinalizedConvention, native relational-model construction and model cache. Upstream #39214 describes the matching check-then-act race; backport #39423 targets unreleased 10.0.16. This temporary test-context startup workaround has a removal comment; it does not reproduce EF's initialization algorithm. No broker capability is involved.Validation: deterministic standalone pinned-EF interleaving reproduced the original exception. The new startup regression failed without the convention (relational model still lazy), then all 55 InboxTests passed on each of net10.0 and net11.0 (110 total), including real PostgreSQL committed-outcome/native-retry tests.
git diff --checkpassed. Local platform is macOS ARM64; hosted Linux x64 remains CI validation. Full diff reviewed for reuse, correctness and performance.No docs impact: test initialization only; no library behavior/API changes. Production per-message cost: unchanged, 0 B added. No CI rerun or threshold relaxation.
Validation evidence:
/Users/tom/git/Relayer-evidence/issue-570/validation-d179ca1/; 588 source, report, log, probe and loaded binary files independently copied/length-SHA256 verified and read back againstinventory.json. Retained locally while #570 is open.Review follow-up: removed the completed batch-allocation diagnostic workflow and normal-test instrumentation in 573afcd, restoring this PR to the inbox model fix alone. The unrelated historical CI failure is tracked in #585, with its original failure log and all diagnostic outcomes preserved; its +56 B cause remains unproven. All sixteen predeclared hosted diagnostic processes passed, which does not replace or explain the failed ready-PR CI run. No CI rerun was requested. Diagnostic sources remain available in b3b0e29 and the retained artifact; no permanent workflow is needed to retain completed evidence.
Focused batch-allocation comparison after removal: 4/4 passed across net10.0 and net11.0 on macOS ARM64. Evidence:
/Users/tom/git/Relayer-evidence/pr-571/573afcd-validation/; all 484 source, loaded-binary, report and log files were copied, independently compared with originals by length/SHA-256, and read back againstinventory.json. The unchanged InboxTests validation above was not rerun.git diff --checkpasses. No production per-message change, 0 B added; no docs impact.