Repository navigation
Define durable outbox dispatch contracts and keyed health adapter - #111
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Review of #111I read the contract changes ( Correctness
Performance
Docs
Non-blocking suggestions
No blocking issues found. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2e4a31f to
0b8f99c
Compare
|
@codex review Rebased onto c6ebcfc and preserved both roadmap additions. The fresh build also exposed the newly merged tracing fixture's missing stable message identity; 0b8f99c adds [Message("send.probe")] and makes the fixture accessible to generated serialization metadata. Disposition of Claude's two non-blocking suggestions in #111 (comment): provider argument validation and a reusable store conformance suite belong with executable database providers. This PR introduces the contract and health adapter only, so neither suggestion changes this head. #109 covers schema/CLI fixtures rather than a dispatch store implementation; database transaction/provider implementations remain in #29, #30 and #41. No runtime provider behavior is left untested by this PR's scope. Validation on the new head: Release solution build passed with zero warnings/errors; all 547 tests passed; win-x64 Native AOT publish and execution passed; npm ci and the website build passed. Verified evidence and SHA-256 inventory: C:/git/Relayer-evidence/pr-111/0b8f99c9f4f08380be23dee9167f3669c6102627. Both reviewers must review this new head before promotion; the PR remains a draft. |
Review of #111 (outbox store contract + health adapter)I read the contract (
No actionable issues. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Red-main follow-up: #103 merged and closed #102; that earlier lock blocker is gone. The current main failure is RLY001 at SendTracingTests.cs:348 in https://github.com/thomhurst/Relayer/actions/runs/41316547316 (5064264). This PR already fixes it by declaring the public Probe fixture with [Message("send.probe")], so a duplicate fix PR is unnecessary. Claude CLEAR and Codex completed without findings both cover current head 0b8f99c. All review surfaces are clear; the older non-blocking suggestions were dispositioned in the previous update. Reverified all 864 archived evidence files against their originals and recorded SHA-256 hashes before promotion. Durable archive: C:/git/Relayer-evidence/pr-111/0b8f99c9f4f08380be23dee9167f3669c6102627 (seven inactive days retention). inventory.csv SHA-256: 81E8B69277E379C8C18EA935FCF659535B5F53384A2F1BEA5660DBEBB613C4AE. The source archive also matches its recorded SHA-256. Existing validation covers the Release solution build, 547 tests, Windows Native AOT and the website build. Promoting and arming this reviewed head through scripts/Enable-AutoMerge.ps1 -Pr 111 -MarkReady. |
The durable outbox providers need a shared dispatch contract and a health adapter that can use scoped database services. This adds bounded row reads, expiring fenced claims, atomic completion/failure contracts, and an eligible-backlog query. The optional keyed health adapter forwards the current UTC instant and cancellation, preserves unavailable counts and database errors, and reports omitted OutboxNames entries as unhealthy.
This delivers the contract/health child of #28. Schema scripts, CLI distribution and real PostgreSQL fixtures remain in #109; database transaction implementations and dispatch workers remain planned. The site documents registration, memory ownership, claim semantics and this implementation boundary. D29 records the claim protocol without rewriting D12's history.
Closes #108
Rebased onto c6ebcfc, preserving both the merged send-tracing roadmap entry and this PR's durable-store entry. The fresh solution build exposed RLY001 in the newly merged SendTracingTests.Probe fixture. The fixture now declares [Message("send.probe")] and is public so the generated JSON context can access it. This small test-only fix restores the solution build; it has no docs impact beyond the existing contract documentation.
Validation on 0b8f99c:
No database implementation changes are claimed or validated by this PR; real database fixtures are acceptance criteria in #109.
Per-message cost: no changes to an executing message path, 0 B added per message. New runtime work occurs only during registration and health polls; no benchmark is required.
Validation evidence is archived outside the worktree at
C:/git/Relayer-evidence/pr-111/0b8f99c9f4f08380be23dee9167f3669c6102627(seven inactive days retention). It contains raw test reports, test binaries, the Native AOT executable/symbols, a source archive and build/test/site logs.inventory.csvrecords source paths, sizes and SHA-256 hashes for 864 files; every copy was verified against its original.source-sha256.txtrecords the source archive hash. This supersedes the earlier validation archive for 2e4a31f, which remains separate.