Repository navigation
Carry main into redesign/main: grounded Astra daily summaries (#746) - #786
Merged
Merged
Conversation
(cherry picked from commit fc5e641)
|
There was a problem hiding this comment.
✅ No Critical or High issues found.
Reviewed changes Reviewed all six changed files in the daily-summary carry into redesign/main.
- Bounded history: Adds 14-day adherence context and full flexible-quota windows while preserving batched log reads.
- Habit selection: Retains skipped habits and excludes satisfied flexible quotas from pending recommendations.
- Grounded prompts: Distinguishes app-wide streaks from habit adherence, includes parent and child history, and constrains completion praise and pending nudges.
- Regression coverage: Verified 81 infrastructure tests and 20 application tests, all passing. Public response contracts remain unchanged; the worktree is clean.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Refs thomasluizon/orbit-tickets#746
Refs thomasluizon/orbit-tickets#48
Carried
fc5e641fusinggit cherry-pick -x --no-commit, then committed after the build and focused tests passed. No conflicts or skipped commits. The committed patch exactly matches the source patch.AppConstants.cs,GetDailySummaryQuery.csandAiSummaryService.csnow provide bounded 14-day adherence history, retain skipped habits, distinguish app-wide streaks, and ground summary claims in recorded activity. All three source test files were carried unchanged. Existing redesign behavior remains intact.No migrations or snapshot changes. OpenAPI regenerated through
dotnet buildwith no resulting diff.Test evidence
Both locale settings passed:
LANGunset andLC_ALL=en_US.UTF-8.dotnet build Orbit.slnx --nologo --verbosity minimalEach full test command used
dotnet test tests/<project> --no-build --nologo --verbosity minimal. Total: 10,311 tests passed per locale.Regression verification used these commands with
LANGunset:TargetModel_PreservesPromotedRedesignAndCombinedSnapshotMatchesCurrentModelpassed, 82 total. That test asserts no pending EF model changes.All pre-commit hooks passed. Both builds reported 19 warnings.
Assumptions
None. The carry applied unchanged.
Manual steps
None.
🤖 Generated with Claude Code