Skip to content

Carry main into redesign/main: grounded Astra daily summaries (#746) - #786

Merged
thomasluizon merged 1 commit into
redesign/mainfrom
thomasluizon/ticket-746-carry-oct19d
Oct 19, 2026
Merged

thomasluizon merged 1 commit into
redesign/mainfrom
thomasluizon/ticket-746-carry-oct19d

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Refs thomasluizon/orbit-tickets#746
Refs thomasluizon/orbit-tickets#48

Carried fc5e641f using git cherry-pick -x --no-commit, then committed after the build and focused tests passed. No conflicts or skipped commits. The committed patch exactly matches the source patch.

AppConstants.cs, GetDailySummaryQuery.cs and AiSummaryService.cs now provide bounded 14-day adherence history, retain skipped habits, distinguish app-wide streaks, and ground summary claims in recorded activity. All three source test files were carried unchanged. Existing redesign behavior remains intact.

No migrations or snapshot changes. OpenAPI regenerated through dotnet build with no resulting diff.

Test evidence

Both locale settings passed: LANG unset and LC_ALL=en_US.UTF-8.

Check Result in each setting
dotnet build Orbit.slnx --nologo --verbosity minimal Exit 0, zero errors
Domain tests 778 passed, exit 0
Application tests 5,591 passed, exit 0
Infrastructure tests 3,942 passed, exit 0

Each full test command used dotnet test tests/<project> --no-build --nologo --verbosity minimal. Total: 10,311 tests passed per locale.

Regression verification used these commands with LANG unset:

env -u LANG dotnet test tests/Orbit.Application.Tests --filter FullyQualifiedName~GetDailySummaryQueryHandlerTests --nologo --verbosity minimal
env -u LANG dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~AiSummaryServiceTests|FullyQualifiedName~QueryRoundTripCountTests' --nologo --verbosity minimal
  • Unchanged tests with the defect present: 15 application and 72 infrastructure tests passed. An initial concurrent application build hit file contention; its serialized rerun passed.
  • Carried tests with implementation unchanged: application exit 1 with two failures; infrastructure exit 1 with ten failures. These exposed missing history, skipped-habit exclusion, unlabeled streaks and satisfied flexible quotas selected as pending.
  • After the carry: 16 application tests passed. Infrastructure focused tests plus TargetModel_PreservesPromotedRedesignAndCombinedSnapshotMatchesCurrentModel passed, 82 total. That test asserts no pending EF model changes.

All pre-commit hooks passed. Both builds reported 19 warnings.

Assumptions

None. The carry applied unchanged.

Manual steps

None.

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Critical or High issues found.

Reviewed changes Reviewed all six changed files in the daily-summary carry into redesign/main.

  • Bounded history: Adds 14-day adherence context and full flexible-quota windows while preserving batched log reads.
  • Habit selection: Retains skipped habits and excludes satisfied flexible quotas from pending recommendations.
  • Grounded prompts: Distinguishes app-wide streaks from habit adherence, includes parent and child history, and constrains completion praise and pending nudges.
  • Regression coverage: Verified 81 infrastructure tests and 20 application tests, all passing. Public response contracts remain unchanged; the worktree is clean.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@thomasluizon
thomasluizon merged commit 13ec369 into redesign/main Oct 19, 2026
22 checks passed
@thomasluizon
thomasluizon deleted the thomasluizon/ticket-746-carry-oct19d branch October 19, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant