[thomasluizon]

Habit logs now require the slip classification that API writers already persist. The contract migration removes the compatibility trigger and function, classifies only remaining NULL values, and requires the column without adding a default.

Closes thomasluizon/orbit-tickets#718

Approach

• src/Orbit.Domain/Entities/HabitLog.cs restores IsSlip to bool; src/Orbit.Infrastructure/Persistence/HabitLogReader.cs filters completions with !log.IsSlip.
• src/Orbit.Infrastructure/Migrations/20261019011031_ContractHabitLogSlip.cs drops the trigger and PostgreSQL function, backfills NULL classifications from the log value and habit flag, then applies the non-null constraint. Explicit historical classifications are preserved, including when a habit has changed type. The generated Designer and model snapshot accompany the migration.
• tests/Orbit.Infrastructure.Tests/Persistence/ContractHabitLogSlipMigrationTests.cs exercises NULL backfill, soft-deleted rows, preservation of explicit classifications, trigger removal, rejection of an insert without classification, rollback SQL and old-schema compatibility. The existing feature-flag migration model test accounts for the additional column alteration.
• The migration was scaffolded with dotnet ef migrations add through OrbitDbContextFactory. OpenAPI documents were regenerated by the build and had no diff.

Rolling deployment

The orchestrator supplied the production barrier evidence: Render service srv-d6tc2isr85hc739bf75g runs live deploy dep-dba7ls5g1s2s73b3lhog on 7472203c7, with the previous deploy deactivated. git merge-base --is-ancestor a1c666f1 7472203c7 also returned exit 0 locally. Every running writer therefore supplies its own classification before this contraction.

The new binary reads and writes the existing nullable column with its expand-phase trigger still installed. The expand migration already backfilled existing rows, and the trigger classifies inserts that omit the column. NewBinary_ReadsAndWritesExpandedSchema verifies full log materialization, another persisted log and the completion-date query for both good and bad habits against that schema. Startup awaits migration before serving requests; the contract transaction repairs any residual NULL values before requiring the column. Existing nullable-model binaries continue reading and writing the same column after contraction. No column is renamed or removed.

Test evidence

All verification used env -u LANG LC_ALL=en_US.UTF-8.

• Before implementation, dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~RecordHabitLogSlipMigrationTests|FullyQualifiedName~HabitLogReaderTests' --nologo passed all 23 unchanged tests while the schema still had the compatibility trigger and nullable classification.
• Against the uncorrected scaffold, dotnet test tests/Orbit.Infrastructure.Tests --filter FullyQualifiedName~ContractHabitLogSlipMigrationTests --nologo failed Up_PostgresBackfillsBeforeRequiringClassificationWithoutDefault: the generated column default was false. Up_BackfillsNullRemovesTriggerAndEnforcesNoDefault(true, 1, true) also failed because the positive bad-habit NULL log became false. These failures were observed before adding the explicit classification backfill and removing the scaffolded default.
• After correction, dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~ContractHabitLogSlipMigrationTests|FullyQualifiedName~RecordHabitLogSlipMigrationTests|FullyQualifiedName~HabitLogReaderTests|FullyQualifiedName~FeatureFlagAccountsMigrationTests' --no-build --no-restore --nologo passed all 36 tests, including both failures above.
• dotnet build Orbit.slnx --nologo: exit 0, 0 errors.
• dotnet test tests/Orbit.Domain.Tests --nologo: exit 0, 736 passed.
• dotnet test tests/Orbit.Application.Tests --nologo: exit 0, 5,573 passed.
• dotnet test tests/Orbit.Infrastructure.Tests --nologo: exit 0, 3,629 passed.
• Commit hooks passed formatting, root allowlist, dash, timeless and suppression checks. Mutation testing remains with CI.

External interface evidence

Tests use the installed EF Core/Npgsql/SQLite providers directly, without mocked migration operations or database response fixtures. Their actual generated SQL and SQLite execution confirm the migration operation fields, provider selection and schema introspection used by these tests. The complete PostgreSQL script below was generated through the design-time factory with this command from src/Orbit.Api:

dotnet ef migrations script RecordDeletionStoppedRenewals ContractHabitLogSlip --project ../Orbit.Infrastructure --startup-project . --context OrbitDbContext --no-build --output /tmp/orbit-718-contract.sql

START TRANSACTION;
DROP TRIGGER IF EXISTS "SetHabitLogIsSlipOnInsert" ON "HabitLogs";
DROP FUNCTION IF EXISTS "SetHabitLogIsSlipOnInsert"();

UPDATE "HabitLogs" AS logs
SET "IsSlip" = logs."Value" > 0 AND
    (SELECT "IsBadHabit" FROM "Habits" WHERE "Id" = logs."HabitId")
WHERE logs."IsSlip" IS NULL;

ALTER TABLE "HabitLogs" ALTER COLUMN "IsSlip" SET NOT NULL;

INSERT INTO "__EFMigrationsHistory" ("MigrationId", "ProductVersion")
VALUES ('20261019011031_ContractHabitLogSlip', '10.0.13');

COMMIT;

Assumptions

• Down restores the nullable expand schema and its old-writer classifier; rejected making the contract migration irreversible.

Manual steps

• After merge and owner approval, use GitHub Actions > Release API > Run workflow with environment=production and branch=main. Approve its production environment deployment. Verify the release job succeeds and Render service srv-d6tc2isr85hc739bf75g > Events shows the selected commit live. The migration applies during API startup; the generated schema checks above are automated tests, and no separate manual backfill or configuration change is required.

[thomasluizon]

Guard proof by the orchestrator, at head aff027a2, each break alone, restored with git checkout and nothing committed (dotnet test tests/Orbit.Infrastructure.Tests --filter FullyQualifiedName~ContractHabitLogSlipMigrationTests, 10 cases pass unbroken):

• Backfill disabled (WHERE logs."IsSlip" IS NULL AND 1 = 0): exit 1, 4 failed, 6 passed; every Up_BackfillsNullRemovesTriggerAndEnforcesNoDefault case that seeds a NULL row fails, including the bad habit slip (value: 1, expected: True).
• Trigger and function drops replaced with SELECT 1: exit 1, Up_PostgresBackfillsBeforeRequiringClassificationWithoutDefault fails.

Production barrier, read by the orchestrator from Render: srv-d6tc2isr85hc739bf75g has one live deploy, dep-dba7ls5g1s2s73b3lhog on 7472203c7 (which contains api#574 a1c666f1); the previous deploy is deactivated. This contract migration reaches production only through a manual production release.

[pullfrog]

✅ No new issues found.

Reviewed changes Reviewed the schema contraction, domain/read-path changes, generated migration model, regression tests, and compatibility with the mobile consumer.

• Schema contraction: Removes the compatibility trigger/function, backfills only NULL classifications, and requires IsSlip without adding a default; rollback restores the nullable schema and classifier.
• Domain and reader: Makes HabitLog.IsSlip non-nullable and retains the completion query's ownership, positive-value, and soft-delete filters while excluding slips.
• Client compatibility: Existing log, sync, and export DTOs and their sibling Zod schemas do not expose IsSlip, so this does not remove or newly require a client-facing field.
• Verification: All 36 focused migration and reader tests passed, including historical-classification preservation, expanded-schema compatibility, and omitted-classification rejection. PostgreSQL SQL generation was exercised; live PostgreSQL execution and the documented Render deployment barrier were not independently verified.

[pullfrog]

✅ No new issues found.

Reviewed changes Reviewed the schema contraction, domain and completion-reader changes, migration model, regression tests, and mobile consumer compatibility.

• Schema contraction: Removes the compatibility trigger and function, backfills only NULL classifications, and requires IsSlip without adding a default. Rollback restores the nullable schema and classifier.
• Domain and reader: Makes HabitLog.IsSlip non-nullable while preserving the completion query's ownership, positive-value, soft-delete, and slip-exclusion semantics.
• Client compatibility: The existing log, sync, and export DTOs and their sibling Zod schemas do not expose IsSlip; no client-facing fields are removed or newly required.
• Verification: All 36 focused migration and reader tests passed. PostgreSQL SQL generation was exercised; live PostgreSQL execution and the documented Render deployment barrier were not independently verified.

  ^{｜ View workflow run ｜ Using gpt-6.1-sol ｜ 𝕏}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud