Skip to content

chore: run the Pullfrog reviewer on the Codex harness with gpt-6.1-sol - #668

Merged
thomasluizon merged 2 commits into
mainfrom
chore/pullfrog-codex-gpt-6-1-sol
Sep 30, 2026
Merged

thomasluizon merged 2 commits into
mainfrom
chore/pullfrog-codex-gpt-6-1-sol

Conversation

@thomasluizon

@thomasluizon thomasluizon commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

What changed

The Pullfrog review step (the "Codex" step, which runs on the stored Codex credential) now reviews with openai/gpt-6.1-sol. The model is passed as a raw specifier because no published Pullfrog alias resolves to gpt-6.1-sol yet (gpt-sol still resolves to openai/gpt-6-sol through release 0.1.86 and on main), and the action's model input overrides the repository console setting. The Claude fallback step, where present, moves from anthropic/claude-opus-5 to anthropic/claude-opus-5-5.

The first version of this pull request also forced the Codex CLI harness (PULLFROG_AGENT: codex) and asked for effort: medium. Review showed both were wrong, so both are gone: the Codex harness disables multi_agent, which removes the reviewfrog specialist sub-agent, and a raw model has no effort rung, so the effort input was never applied. The step stays on the default opencode harness, where reviewfrog inherits the main model.

Test evidence

  • actionlint .github/workflows/pullfrog.yml: clean.
  • Model pass-through: the pinned release's resolveModel (utils/agent.ts) returns a slashed value that is not a curated alias unchanged, as a raw models.dev specifier.
  • Effort: resolveRunEffort (utils/runEffort.ts:107-132 at release 0.1.85) returns rung: undefined when the model has no catalog alias, and the opencode harness sends a variant only when a rung exists (agents/opencode.ts:1188-1192, 1394). With no variant the model runs at its default, and OpenAI documents reasoning.effort for gpt-6.1-sol as "low, medium (default), high, xhigh, and max" (https://developers.openai.com/api/docs/models/gpt-6.1-sol).
  • Specialist sub-agent: deriveSubagentModels (agents/subagentModels.ts) returns no override for a model with no alias, so reviewfrog logs (inherit) and runs on the main model.
  • The last review run on orbit-ui-mobile (run 36639474167) logged BYOK auth enabled ... openai/gpt-6.1-sol for the stored Codex credential, model: openai/gpt-6-sol (resolved from openai/gpt-sol) and agent: opencode. The first review after merge must log model: openai/gpt-6.1-sol, agent: opencode and effort: n/a.

🤖 Generated with Claude Code

The Codex step now sets PULLFROG_AGENT=codex and passes openai/gpt-6.1-sol
as a raw model specifier, because no published Pullfrog alias resolves to it
yet. The Claude fallback moves to claude-opus-5-5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The requested medium reasoning effort is not applied to the new model, so the review runs at the Codex CLI's default effort instead of the configured level.

Reviewed changes in the Pullfrog workflow configuration:

  • Primary reviewer: Selects the Codex harness and pins openai/gpt-6.1-sol with medium effort.
  • Failure fallback: Updates the Claude model to anthropic/claude-opus-5-5 while retaining the failure-only trigger.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using GPT Sol | 𝕏

Comment thread .github/workflows/pullfrog.yml Outdated
…l's default effort

The Codex CLI harness disables multi_agent, which drops the reviewfrog
specialist sub-agent, and a raw model specifier has no effort rung, so the
effort input was never applied. The review step keeps openai/gpt-6.1-sol on
the default opencode harness, where OpenAI's documented default effort is
medium.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes since the prior Pullfrog review:

  • Restored the default harness: Removed the forced Codex CLI harness so the reviewer retains the reviewfrog specialist.
  • Clarified effort behavior: Removed the ignored effort: medium input and documented that the raw model runs at its default effort, which OpenAI documents as medium.

Pullfrog  | View workflow run | Using GPT Sol | 𝕏

@sonarqubecloud

Copy link
Copy Markdown

@thomasluizon
thomasluizon merged commit c95d548 into main Sep 30, 2026
26 checks passed
@thomasluizon
thomasluizon deleted the chore/pullfrog-codex-gpt-6-1-sol branch September 30, 2026 14:55
thomasluizon added a commit that referenced this pull request Sep 30, 2026
* Delete the deprecated POST /oauth/google route (#957) (#664)

The MCP authorize page moved to the authorization-code redirect through
/oauth/google/start and /oauth/google/callback, so the One Tap tokeninfo
route kept no caller in either app or in any documented client. It also
created users through a raw repository call instead of an application
command.

Remove the route, its GoogleAuthRequest record, FindOrCreateGoogleUserAsync,
the now orphaned user repository and HTTP client factory dependencies, the
OAuthController.GoogleAuth catalog entry and the GoogleTokenAudienceMismatch
error, and regenerate openapi.json. The route stayed deprecated on main, so
oasdiff reports the removal as api-path-removed-with-deprecation at INFO and
the breaking-change gate passes.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit e596ee1)

* chore: run the Pullfrog reviewer on the Codex harness with gpt-6.1-sol (#668)

* chore: run the Pullfrog reviewer on the Codex harness with gpt-6.1-sol

The Codex step now sets PULLFROG_AGENT=codex and passes openai/gpt-6.1-sol
as a raw model specifier, because no published Pullfrog alias resolves to it
yet. The Claude fallback moves to claude-opus-5-5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: keep the Pullfrog reviewer on the opencode harness at the model's default effort

The Codex CLI harness disables multi_agent, which drops the reviewfrog
specialist sub-agent, and a raw model specifier has no effort rung, so the
effort input was never applied. The review step keeps openai/gpt-6.1-sol on
the default opencode harness, where OpenAI's documented default effort is
medium.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit c95d548)

* Transfer or release a device's push subscription when it changes accounts (#932) (#667)

* Transfer a device's push subscription when another account registers it

A device keeps one push endpoint or FCM token across the accounts that
sign in on it. Before, a second account got PUSH_ENDPOINT_OWNED_BY_OTHER_USER,
the client rotated the endpoint, and the first account kept a dead row that
counted toward its five-device cap.

Now the row moves to the registering account when the request proves it
holds the device: a Web Push request must present the stored p256dh key
and auth secret, and an FCM request must present the stored token with
the FCM sentinel. A request without that proof still gets the old error,
so an account cannot take or remove another account's device.

Refs thomasluizon/orbit-tickets#932

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Let the account on a device release its prior account's push row

Unsubscribe only removed a row the caller owned. When a browser or
Android device stayed registered to a previous account and the account
now signed in turned push off, the client dropped the endpoint locally
while the previous account kept listing and counting a dead device.

Unsubscribe now takes the device's p256dh and auth, which both clients
already send, and removes another account's row only when they prove
control of the device, using the same check as the subscribe transfer.
Without that proof the row stays with its owner and the call still
returns success, so it does not reveal who owns an endpoint.

Refs thomasluizon/orbit-tickets#932

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: require explicit cross-account push subscription release

* fix: bind push unsubscribe deletion to the observed owner

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit ce78ccb)

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant