[thomasluizon]

Closes thomasluizon/orbit-tickets#913

Approach

Search now traverses every incomplete child branch even when the child has no visible occurrence in the requested date range. A child contributes its own search match only when it is relevant on that range. This preserves the existing due and overdue rules while allowing a due grandchild to keep its root in the results.

The change is in src/Orbit.Application/Habits/Queries/HabitScheduleFilters.cs. Regression coverage in tests/Orbit.Application.Tests/Queries/Habits/GetHabitScheduleQueryHandlerTests.cs exercises skipped flexible and unscheduled weekly middle children, excludes their own title matches, checks the due grandchild metadata, and compares the regular schedule response.

Assumptions

• A middle child with no occurrence remains in the response as a navigation container for its due descendant, with empty scheduled dates. I rejected dropping the container because the existing non-search mapping keeps branches with due descendants.

Test evidence

• Before edits, env -u LANG LC_ALL=en_US.UTF-8 dotnet test tests/Orbit.Application.Tests/Orbit.Application.Tests.csproj --filter 'FullyQualifiedName~Handle_SearchMatchesDescendantField_PreservesDateAndOverdueGates' --verbosity normal passed both cases with the defect present.
• After strengthening that test and before changing production code, the same command with --no-restore --verbosity minimal failed both cases because the result omitted the root with a due grandchild beneath a future middle child.
• After the fix, env -u LANG LC_ALL=en_US.UTF-8 dotnet test tests/Orbit.Application.Tests/Orbit.Application.Tests.csproj --filter 'FullyQualifiedName~Handle_SearchMatchesDescendantField_PreservesDateAndOverdueGates|FullyQualifiedName~Handle_SearchTraversesHiddenMiddleChild|FullyQualifiedName~Handle_SearchMatchesOnlyHiddenMiddleChild' --verbosity minimal passed all 6 cases.
• env -u LANG LC_ALL=en_US.UTF-8 dotnet build Orbit.slnx --verbosity quiet exited 0 with 0 errors.
• env -u LANG LC_ALL=en_US.UTF-8 dotnet test --verbosity quiet exited 0 with 6,934 passed and 0 failed.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pullfrog]

✅ No new issues found.

Reviewed changes Search traversal and match attribution for date scoped habit schedules, including the regression tests.

• Descendant traversal: Incomplete hidden middle children no longer prevent a due grandchild from satisfying the root search.
• Match metadata: A hidden child's own fields no longer count as matches, while its relevant descendants still appear in ancestor metadata.
• Regression coverage: Positive and negative cases cover skipped flexible and off-date weekly middle children, plus due and overdue attribution.

  ^{｜ View workflow run ｜ Using GPT Sol ｜ 𝕏}