Skip to content

馃悰 Prevent attempt status lockout on skipped essay questions - #3074

Merged
harunollyo merged 3 commits into
4.2.0from
fix/quiz-status
Oct 14, 2026
Merged

馃悰 Prevent attempt status lockout on skipped essay questions#3074
harunollyo merged 3 commits into
4.2.0from
fix/quiz-status

Conversation

@b-l-i-n-d

@b-l-i-n-d b-l-i-n-d commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator
  • Prevents quiz attempts containing skipped essay questions from being permanently locked in a Pending status.
  • Avoids requiring instructor manual review when open-ended or short-answer questions are skipped without student input.
  • Transitions attempt status from review_required to attempt_ended once non-pending evaluation is finalized, without marking skipped questions as incorrect.

@b-l-i-n-d
b-l-i-n-d requested review from sazedul-haque and shewa12 and removed request for sazedul-haque October 8, 2026 12:41
@b-l-i-n-d b-l-i-n-d self-assigned this Oct 8, 2026
@b-l-i-n-d b-l-i-n-d added bug Something isn't working 4.2.0 labels Oct 8, 2026
@b-l-i-n-d
b-l-i-n-d marked this pull request as ready for review October 8, 2026 12:42
harunollyo
harunollyo requested changes Oct 14, 2026
View reviewed changes
Comment thread models/QuizModel.php Outdated
public static function update_attempt_result( $attempt_id ) {
$attempt_result = self::prepare_attempt_result( $attempt_id );
if ( $attempt_result ) {
if ( self::RESULT_PENDING !== $attempt_result ) {

@harunollyo harunollyo Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be dangerous because update_attempt_result is called in many places. If the result is not PENDING, it will be changed to REVIEW_REQUIRED.

@b-l-i-n-d b-l-i-n-d Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@harunollyo
harunollyo merged commit 1587399 into 4.2.0 Oct 14, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harunollyo harunollyo harunollyo approved these changes
@shewa12 shewa12 Awaiting requested review from shewa12

Assignees

@b-l-i-n-d b-l-i-n-d

Labels

4.2.0 bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@b-l-i-n-d @harunollyo