Repository navigation
Multiple security issues resolved in QueryHelper - #3046
Open
harunollyo wants to merge 16 commits into
Open
harunollyo wants to merge 16 commits into
harunollyo wants to merge 16 commits into
Conversation
harunollyo
marked this pull request as draft
October 1, 2026 06:15
…quoting column names and identifiers
shewa12
reviewed
Oct 7, 2026
shewa12
reviewed
Oct 7, 2026
shewa12
reviewed
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple SQL injection vulnerabilities in
QueryHelperby validating and quoting user-influenced identifiers (column names, table names, ORDER BY values) and preparing previously unprepared variables.Changes
get_row/get_all: Sanitize theORDER BYclause to block injection via unescaped order values.update_where_in: Prepare variables that were previously interpolated directly into the query.prepare_set_clause(): Escape and quote column names.prepare_like_clause(): Validate array keys used as column names.quote_sql_identifier(): Helper that validates and backtick-quotes SQL identifiers. It is now used forwhere_coland table names acrossQueryHelperqueries.Testing
Unit tests added for the new behavior:
vendor/bin/phpunit --filter=QueryHelperTest