Skip to content

Fixes #39248 - Migrate tests to Minitest - #956

Open
jakduch wants to merge 1 commit into
theforeman:developfrom
jakduch:fix/39248
Open

jakduch wants to merge 1 commit into
theforeman:developfrom
jakduch:fix/39248

Conversation

@jakduch

@jakduch jakduch commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

What changed

  • migrate the Smart Proxy test suite from test-unit to Minitest
  • replace ci_reporter with minitest-reporters for Jenkins JUnit output
  • load the CI reporter only when Jenkins is running
  • update Test::Unit-specific assertions and the Mocha/WebMock integrations

Why

ci_reporter_test_unit is unmaintained and its integration broke when Rake 13.4.2 changed how verbose test options are passed. PR #938 fixed the immediate test invocation failure, but left the obsolete reporting stack in place. This change completes the migration described in the issue and removes that dependency.

Validation

  • checked Ruby syntax for all files under test, lib, modules, and tasks
  • checked the diff for whitespace errors

Full test execution is left to the upstream Ruby matrix because the local Docker runtime was unavailable.

AI assistance disclosure: This pull request was prepared with assistance from Codex 5.6 Sol High. The changes were reviewed by the author.

@jakduch
jakduch force-pushed the fix/39248 branch 4 times, most recently from 7229ba4 to f0389b3 Compare August 19, 2026 22:15
@jakduch
jakduch force-pushed the fix/39248 branch 3 times, most recently from 711d93e to 974e533 Compare October 2, 2026 14:25
Replace the unmaintained test-unit CI reporter integration with Minitest and minitest-reporters. Convert the test suite to Minitest assertions and only enable JUnit reporting in Jenkins.

Assisted-By: Codex 5.6 Sol High <noreply@openai.com>
@jakduch

jakduch commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Ruby CI is green now. The three DHCPFreeIps failures came from the test depending on global Proxy::DhcpPlugin.settings initialized by another test file, so I made the setup explicit with load_test_settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant