Skip to content

Fixes #39824 - Expose partition table snippets - #663

Merged
ofedoren merged 1 commit into
theforeman:masterfrom
jakduch:feature/ptable-snippet
Oct 13, 2026
Merged

ofedoren merged 1 commit into
theforeman:masterfrom
jakduch:feature/ptable-snippet

Conversation

@jakduch

@jakduch jakduch commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What

  • show the snippet flag in partition table list output
  • show it in partition table info output as a boolean
  • cover both output definitions in unit tests

Why

Implements Redmine #39824: https://projects.theforeman.org/issues/39824

This is the Hammer CLI part of Foreman #39266 and a follow-up to theforeman/foreman#11276, which exposes the existing partition table snippet flag in API responses.

Testing

  • bundle exec ruby -I. test/unit/partition_table_test.rb (34 runs, 44 assertions)
  • git diff --check

AI assistance disclosure:

  • Assisted by Codex.

@ofedoren

Copy link
Copy Markdown
Member

Thanks, @jakduch, approved and can be merged along with the main PR.

Although, we still use ticket system here, so could you please fill a Redmine ticket and link it to the one filed for Foreman as related. And, of course, use the number for the commit message.

@jakduch
jakduch force-pushed the feature/ptable-snippet branch from a0ea288 to 5af4fe4 Compare September 30, 2026 14:13
@jakduch

jakduch commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Done, thanks for the reminder. I created Redmine #39824, linked it as related to Foreman #39266, added this PR to it, and updated the commit message to Fixes #39824 - Expose partition table snippets.

@ofedoren ofedoren changed the title Expose partition table snippet flag Fixes #39824 - Expose partition table snippets Oct 13, 2026

@ofedoren ofedoren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jakduch !

@ofedoren
ofedoren merged commit d481c3f into theforeman:master Oct 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants