Repository navigation
Upgrade cleanup - #983
Draft
evgeni wants to merge 2 commits into
Draft
Upgrade cleanup#983evgeni wants to merge 2 commits into
evgeni wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
evgeni
force-pushed
the
upgrade-cleanup
branch
from
November 6, 2026 12:30
e417aff to
7ac7f2d
Compare
evgeni
force-pushed
the
upgrade-cleanup
branch
from
November 6, 2026 13:44
7ac7f2d to
a12c063
Compare
evgeni
commented
Nov 9, 2026
| path: /var/lib/pgsql/data/postgresql.conf | ||
| register: _postgresql_old_conf | ||
|
|
||
| - name: Adjust foreman-installer created PostgreSQL configuration |
Member
Author
There was a problem hiding this comment.
This works (as in: the instance is starting fine and we can use it), but we get config drift between instances that were originally set up by foreman-installer (and thus can carry more custom config) vs the ones created by foremanctl.
I think shipping a "default" postgresql.conf and pg_hba.conf as it is deployed by the container setup and replacing the one from the installer with it is the cleaner path long term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist