Skip to content

Upgrade cleanup - #983

Draft
evgeni wants to merge 2 commits into
masterfrom
upgrade-cleanup
Draft

evgeni wants to merge 2 commits into
masterfrom
upgrade-cleanup

Conversation

@evgeni

@evgeni evgeni commented Nov 6, 2026

Copy link
Copy Markdown
Member

Why are you introducing these changes? (Problem description, related links)

What are the changes introduced in this pull request?

How to test this pull request

Steps to reproduce:

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

path: /var/lib/pgsql/data/postgresql.conf
register: _postgresql_old_conf

- name: Adjust foreman-installer created PostgreSQL configuration

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works (as in: the instance is starting fine and we can use it), but we get config drift between instances that were originally set up by foreman-installer (and thus can carry more custom config) vs the ones created by foremanctl.

I think shipping a "default" postgresql.conf and pg_hba.conf as it is deployed by the container setup and replacing the one from the installer with it is the cleaner path long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant