[jakduch]

Why are you introducing these changes? (Problem description, related links)

The backup success-path fixture can run while Foreman still has asynchronous tasks in progress, which makes the command correctly refuse to start and turns otherwise successful integration runs red.

Closes issue #894.

What are the changes introduced in this pull request?

• Run the backup integration command with --wait-for-tasks.
• Add a focused assertion for the exact command built by the fixture.
• Keep the production default fail-fast behavior unchanged.

How to test this pull request

Steps to reproduce:

• OBSAH_STATE=/private/tmp/foremanctl-894-state python -m pytest tests/backup_test.py::test_backup_command_waits_for_tasks -vv
• ruff check tests/backup_test.py

Checklist

• Tests added/updated (if applicable)
• Documentation updated (not applicable)

This change was prepared with AI assistance.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 799f0fc0-7c49-49a5-aba1-cb16374f7c88

📥 Commits

Reviewing files that changed from the base of the PR and between 2709004 and 2c7a600.

📒 Files selected for processing: 1

• tests/backup_test.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jakduch]

The current exact-head failure is in the fapolicyd content-proxy job: all containers disappear and subsequent commands fail with /bin/bash: Operation not permitted. That shared cache-exhaustion problem is addressed by #893; the backup task-wait change is not involved. I am leaving this branch unchanged until #893 is available.