Repository navigation
Conversation
Enforce parent-user authorization before creating a personal access token. A caller with token creation permission must not be able to create a token for another account without permission to edit that user. Add authorized user lookup to UserAware (cherry picked from commit f77a94d)
Enforce parent-user authorization before creating a personal access token. A caller with token creation permission must not be able to create a token for another account without permission to edit that user. Fix cross-user personal access token authorization (cherry picked from commit d59207e)
Enforce parent-user authorization before creating SSH keys. A caller with SSH key creation permission must not be able to attach a key to another account without permission to edit that user. Fix cross-user SSH key authorization (cherry picked from commit 048acce)
Require provisioning-template permission for host template API access. Host visibility alone must not grant access to sensitive values rendered by provisioning templates. Preserve host visibility checks and the existing ENC permission. Restrict host template API access (cherry picked from commit 2435e0b)
Require provisioning-template permission for host template API access. Host visibility alone must not grant access to sensitive values rendered by provisioning templates. Preserve host visibility checks and the existing ENC permission. Test host template API permissions (cherry picked from commit 27bf969)
Authorize the target user before reading or modifying mail notifications. Reject unauthorized cross-user requests before processing can disclose subscriptions or persist configuration changes. Extract authorized user lookup concern (cherry picked from commit a978211)
Authorize the target user before reading or modifying mail notifications. Reject unauthorized cross-user requests before processing can disclose subscriptions or persist configuration changes. Fix mail notification user authorization (cherry picked from commit f90b756)
Authorize the target user before reading or modifying mail notifications. Reject unauthorized cross-user requests before processing can disclose subscriptions or persist configuration changes. Strengthen mail notification authorization tests Backport tests using the release-compatible notification fixtures and attributes. Do not require newer notification factories or skip behavior. (cherry picked from commit ce9f23a)
net-ping 2.1.0 added a runtime dependency on cap2, whose native extension requires libcap headers to compile. Affects both GitHub Actions CI (rubocop and tests jobs) and the production container image's dnf-based builder stage. (cherry picked from commit 64288e7)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Backport of #11383 to
3.19-stable. Mainline review is still open; this PR references its actual public commit objects with-x, not a synthetic merge commit.The eight source commits remain separate, with original authorship and dates. They enforce parent-user authorization for PAT, SSH key and mail-notification changes, and the additional host-template rendering permissions. Shared prerequisites are included once. Permitted self/admin operations and ENC's
view_hostsbehavior are preserved.Stable compatibility
Host-template tests retain the two intended regression scenarios. Mail-notification tests use this release's available fixtures and attributes rather than newer fixture traits or notification options. No authorization assertions are weakened.
A separate upstream CI prerequisite installs libcap development headers for cap2 compilation: 64288e7. It is retained as its own signed cherry-pick.
Testing
Local results on the unchanged staged source, not a claim about this PR's GitHub Actions:
Review scenarios: denied cross-user PAT/SSH/mail operations; no subscription writes after mail denial; permitted self/admin behavior; required host-template permissions; unchanged ENC access.