Repository navigation
Conversation
Member
Author
|
I've changed the PR a bit:
I can leave any combo of the commits, although I'd prefer to include all of them and squash. |
Move the revision collection route into the earlier constrained ptable declaration. Keep the complete resource declaration unconstrained so child IDs retain their format suffix parsing while dotted ptable IDs remain supported. Cover locations, organizations and operating systems with and without JSON suffixes under both API URL forms.
Use one resource declaration and define standard member routes explicitly so dotted ptable IDs remain supported without constraining nested resource IDs. Declare collection routes first to preserve revision routing. Cover CRUD and custom routes, nested operating system actions and URL helpers for both API URL forms.
ofedoren
force-pushed
the
bug-40037-fix-ptable-routes
branch
from
November 12, 2026 19:58
3ef19b5 to
c06018e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info in the https://projects.theforeman.org/issues/40037. Found as part of #11377.