Repository navigation
Conversation
34746f3 to
f1239d0
Compare
kmalyjur
left a comment
kmalyjur
left a comment
There was a problem hiding this comment.
Other than that, it works well, but I'm not 100% sure that it's not breaking anything, so I would appreciate a re-review from someone else.
| const allDependencies = { ...dependencies, ...devDependencies }; | ||
| // Nested copies of these (uuid 8, yup 0.32, reselect 4) get registered beside | ||
| // the top-level packages. Singleton then picks the higher version and warns. | ||
| const unsharedDependencies = new Set(['uuid', 'yup', 'reselect']); |
There was a problem hiding this comment.
I haven't seen the react-bootstrap warning yet, but shouldn't it be in this set too in order to disappear?
There was a problem hiding this comment.
@kmalyjur react-bootstrap does not need to be in this set. shared() only registers dependencies from Foreman's package.json, and react-bootstrap was removed there in #10624. The old warning was 0.33.1 required ~0.32.0, which is how webpack prints that old ^0.32.0 range against the hoisted 0.33.1 copy. Nothing registers it now, so the warning is already gone. Katello still depends on ^0.32.1, but plugin builds consume this same Foreman share map and do not publish their own copy.
There was a problem hiding this comment.
Makes sense, thank you very much for the explanation
Summary
uuid,yup, andreselectin the webpack module-federation scope so nested copies (uuid 8.3.2, yup 0.32.11, reselect 4.1.8) are no longer published as singletons and the Hosts page no longer logs unsatisfied-version warnings. SAT-37376data:in the Content-Security-Policymedia-srcdirective, matching the existingimg_srcexception.hidden-source-mapso pluginremoteEntry.jsfiles do not reference.mapURLs that snaps do not serve.Test plan
Unsatisfied versionwarnings foruuid,yup,reselect, orreact-bootstrap.media-srcContent-Security-Policy violation for adata:URL.NODE_ENV=productionand confirm*_remoteEntry.jshas nosourceMappingURLcomment and devtools does not 404 on*_remoteEntry.js.map.GET /api/v2/users/:id/table_preferences/hostscan still return 404 when that user has no saved columns.