[jakduch]

What

Enable the Rails Active Storage engine, add its database schema, and configure isolated disk services for development, test, and production. Generic Active Storage routes stay disabled so each consumer must authorize attachment access in its own controller.

This revives the framework portion of #9339 without the PostgreSQL blob adapter. S3 configuration and plugin migrations can follow as separate, reviewable changes. The RPM runtime is being prepared in foreman-packaging#14207 and its dependency chain.

Test

• PostgreSQL 13 migration
• test/unit/active_storage_test.rb: isolated test service, blob write/read/purge round-trip, and disabled generic attachment routes
• RuboCop on all changed Ruby files

Developed with assistance from OpenAI Codex (GPT-5.6 Sol High).

[jakduch]

The JavaScript failures are unrelated date-boundary flakes in the existing DateTimePicker tests. The run just before UTC midnight failed the “current date with future time” case because +1 hour crossed into the next day while the test kept the old date; the run just after midnight failed the symmetric “current date with past time” case because -1 hour crossed into the previous day while keeping the new date. See the pre-midnight job and post-midnight job. This PR does not change JavaScript or DateTimePicker.

[lzap]

Misclicked and requested CoPilot review, sorry.

[Copilot]

🟢 Approval recommended

The implementation is consistent with Rails 7 conventions and includes focused coverage for the enabled behavior.

0 open findings

What changed in this PR

Enables Rails Active Storage with isolated disk services while keeping generic attachment routes disabled.

Changes:

• Enables the Active Storage engine and database schema.
• Configures environment-specific disk storage.
• Tests storage round-trips and route isolation.

File	Description
config/​application.rb	Enables Active Storage and disables generic routes.
config/​storage.yml	Defines disk storage services.
config/​environments/​development.rb	Selects development storage.
config/​environments/​test.rb	Selects isolated test storage.
config/​environments/​production.rb	Selects production-local storage.
db/​migrate/​20261003000000_create_active_storage_tables.rb	Adds Active Storage tables and constraints.
test/​unit/​active_storage_test.rb	Verifies configuration, persistence, cleanup, and disabled routes.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[stejskalleos]

What's the use case here? What Foreman's features require active storage?

[adamruzicka]

I'm pretty sure there are places (openscap comes to mind) where we had to roll our own blob storage just because we had no other option. I'd be in favor of making things as vanilla rails-y as possible and this feels like a step in that direction, even if we don't immediately require it as a dependency for something else.

[stejskalleos]

I'd be in favor of making things as vanilla rails-y as possible and this feels like a step in that direction, even if we don't immediately require it as a dependency for something else.

Agree.

The code changes LGTM, I'd like to have second ack, just for sure, @adamruzicka please

[adamruzicka]

I let AI quickly cobble up a poc for the openscap consumer of this, seems to work well.

[adamruzicka]

Thank you @jakduch !