Repository navigation
Support BSDs by special-casing Linux and Android specifically - #158
Closed
ryanavella wants to merge 1 commit into
Closed
ryanavella wants to merge 1 commit into
ryanavella wants to merge 1 commit into
Conversation
… This ensures the crate can compile on FreeBSD, OpenBSD, NetBSD, and DragonflyBSD.
Collaborator
|
Why: |
Author
|
Interesting, I didn't realize |
Collaborator
|
unsurprisingly, that works: |
Merged
Collaborator
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of gross, but at least gets the crate compiling on the BSDs that don't have an ioctl for querying block size. Solves #157.
To be honest I don't understand this code-base enough to know the "proper" fix. I'd like to understand why the ioctl is needed in the first place, instead of relying exclusively on
std::fs::MetaData::lenwhen that is present. This understand could help me to craft the "proper" patch for FreeBSD support.