Skip to content

::devMode and ::prodMode with optional parameter? #728

Open
Open
::devMode and ::prodMode with optional parameter?#728

Description

@josefsabl
josefsabl
opened on Feb 3, 2025

Maybe the GraphQLite\SchemaFactory::devMode and GraphQLite\SchemaFactory::prodMode could accept an optional parameter like this:

function devMode(bool $v = true);
function prodMode(bool $v = true);

This way, instead of:

$schemaFactory
  ->addNamespace
  ->setFinder(...);

if (DEV_MODE) {
  $schemaFactory->devMode();
} else {
  $schemaFactory->prodMode();
}

One could simply write:

$schemaFactory
  ->addNamespace
  ->setFinder(...);
  ->devMode(DEV_MODE);

Activity

  1. enricobono commented on Feb 6, 2025

    @enricobono
    enricobono
    on Feb 6, 2025

    Hello @josefsabl.
    What's the need behind your proposal?

  2. oojacoboo commented on Feb 6, 2025

    @oojacoboo
    oojacoboo
    on Feb 6, 2025
    Collaborator

    @josefsabl I agree that the API is unfortunate... This wouldn't be a BC break and I'm open to a PR. Thanks.

  3. oprypkhantc commented on Feb 12, 2025

    @oprypkhantc
    oprypkhantc
    on Feb 12, 2025
    Contributor

    Yeah I noticed that one too. devMode could just default to false, and accept a default parameter of true:

    class SchemaFactory {
    private bool $devMode = false;

    public function devMode(bool $value = true): self
    {
        $this->devMode = $value;

        return $this;
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions