fix: Support docker build output for Docker Desktop v4.31 - #423
Conversation
Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for parsing Docker image IDs from Docker v4.31 build output. The new version of Docker outputs image IDs in a different format using "naming to moby-dangling@..." instead of the previously supported "writing image..." format.
- Adds a new regex pattern to parse Docker v4.31 output format
- Maintains backward compatibility with existing Docker output formats
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if line =~ /naming to moby-dangling@(sha256:[[:xdigit:]]{64})(?: \d*\.\ds)? done/i | ||
| img_id = line[/naming to moby-dangling@(sha256:[[:xdigit:]]{64})(?: \d*\.\ds)? done/i, 1] |
There was a problem hiding this comment.
The regex pattern /naming to moby-dangling@(sha256:[[:xdigit:]]{64})(?: \d*\.\ds)? done/i is duplicated on consecutive lines. Consider extracting it to a variable to improve maintainability and performance. For example: pattern = /naming to moby-dangling@(sha256:[[:xdigit:]]{64})(?: \d*\.\ds)? done/i then use if line =~ pattern and img_id = line[pattern, 1].
Description
Add image build parser that works for Docker Desktop v4.31.0
Issues Resolved
resolves #419
Type of Change
fix
Check List