Repository navigation
fix(discovery-server): expose icto and psiid of applications - #858
Merged
Merged
Conversation
stefan-ctrl
marked this pull request as draft
November 11, 2026 15:28
…application-external-ids
stefan-ctrl
marked this pull request as ready for review
November 13, 2026 12:07
… responses Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rule 13 only recognised controller-runtime scoping (label selectors, ScopedClient, commented InNamespace), so every common-server store read in REST servers was a candidate that could only be silenced with an audit ignore. Describe how store reads are environment-scoped (environment-derived Get keys, same-environment references, EnforcePrefix/namespace-bound List options, pass-through helpers), add sourced allowed examples and an unscoped store List violation, and drop the six audit ignores this replaces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…e store GET /applications loaded and mapped every application in scope, then dropped non-matching ones in memory. Translate the icto/psiid query filters into exact-match store filters on spec.externalIds instead, so non-matching applications never leave the store. Add specs against a real in-memory store, because the suite's mock ignores ListOpts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ron96g
requested review from
julius-malcovsky,
lukas016 and
ron96g
and
a balanced review from Copilot
November 16, 2026 10:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the application-identifier and environment-scoped discovery changes.
No open issues 🎉
1 file not reviewed
discovery-server/internal/api/server.gen.go: Generated file
Review effort: Balanced
lukas016
approved these changes
Nov 17, 2026
dtit-semantic-release Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
## [0.48.3](v0.48.2...v0.48.3) (2026-11-18) ### Bug Fixes * **api,event,gateway:** preserve encoded upstream paths in gateway routes ([#837](#837)) ([551f3be](551f3be)) * **discovery-server:** expose icto and psiid of applications ([#858](#858)) ([1237c46](1237c46)) * **rover,event:** additional publishers get a client ([#872](#872)) ([af3d8e2](af3d8e2)) ### Performance Improvements * **rover-server:** stop resolving secrets when listing rovers ([#870](#870)) ([50a5f62](50a5f62))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The discovery API never returned
icto/psiid, even though the Application CRD stores them inspec.externalIds. The?icto=and?psiid=filters were accepted but ignored.GET /eventtypeslisted event types from every environment. The route is unguarded (public), so no access prefix was set and the list was not restricted.Fix
icto/psiidon applications, andictoonApplicationRef(API/event subscriptions, event exposures).GET /applicationsby exacticto/psiidmatch; pagination links keep the filters.apidis still not supported (no CRD stores it).GET /eventtypesto the caller's environment (<env>--namespace prefix), still across all teams. A missing environment returns 500.Validation
make testandmake lintpass indiscovery-server. New unit and controller tests cover the mapping and filters. Snapshots only gain theicto/psiidlines. A new controller test checks thatGET /eventtypesreturns other teams' event types but excludes other environments, including a look-alike prefix (poc-other).