Repository navigation
Fix Ctrl+S shortcut handling in media viewer - #31509
Open
mymindinsane wants to merge 2 commits into
Open
mymindinsane wants to merge 2 commits into
mymindinsane wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31437
Possible cause
Ctrl+Sis also registered as theStashMessagecommand incore/shortcuts.cpp, usingQt::ApplicationShortcut.When the media viewer receives a
QEvent::ShortcutOverrideforCtrl+S, the event filter returnstruewithout explicitly accepting the event. This may allow the application-wide shortcut to take priority, preventing the media viewer from receiving the normal key press.Fix
Call
event->accept()when handlingQKeySequence::SaveorQKeySequence::SaveAsinOverlayWidget::filterApplicationEvent().As described in the Qt documentation, a
QEvent::ShortcutOverridemust be explicitly accepted for the override to take effect.Testing
Tested on Windows 11 with Qt 6:
Ctrl+Sopens the Save As dialog in the media viewer.Ctrl+Shift+Scontinues to work.Ctrl+Sstill performs the existing draft action in the chat editor.The video below compares the original behavior with the fix:
2026-10-23.22-27-34.mp4