Repository navigation
Conversation
next.config.js は BASE_PATH から basePath / assetPrefix を設定し、クライアント用の NEXT_PUBLIC_BASE_PATH を生成する。 .env.example の NEXT_PUBLIC_BASE_PATH を設定してもサブパス公開にならなかったため、BASE_PATH に置き換える。 NEXT_PUBLIC_BASE_PATH は next.config.js が生成するため、.env.example との整合性テストの対象から外す。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
.env.exampleのサブパス公開の項目がNEXT_PUBLIC_BASE_PATHになっていますが、next.config.jsが読むのはBASE_PATHです。.env.exampleのとおりにNEXT_PUBLIC_BASE_PATHを設定してもbasePathとassetPrefixが設定されず、サブパスで公開できません。LivLiv Player 対応(#639)の作業中に気づきました。変更内容
.env.example:NEXT_PUBLIC_BASE_PATH=""をBASE_PATH=""に変更envExampleConsistency.test.ts:NEXT_PUBLIC_BASE_PATHはnext.config.jsがBASE_PATHから作るため、.env.exampleになくてもよい変数として扱う確認
npm test: 220 suites / 2399 passed, 7 skippedご確認よろしくお願いいたします。
meko
🤖 Generated with Claude Code
Summary by CodeRabbit
設定変更
BASE_PATHを使用するよう変更しました。テスト