Repository navigation
Conversation
…ransaction stops chain.dat loading
Owner
|
there is merge conflict please resolve it first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
What I changed
One sentence in the README "Saving" section. It said "Change either one and the file stops loading". It now says that adding a field or a method still loads, and that a change Java serialization treats as incompatible (for example changing a field's type, or bumping
serialVersionUIDinBlock) makes the file stop loading and the program start a new chain. No code changes.How it works
chain.datis a Java serialized object.Block,TransactionandBlockchainpinserialVersionUID, so compatible edits such as a new field or method deserialize fine, while an incompatible edit throwsInvalidClassException, whichStorage.loadcatches before it starts a new chain. I checked the new wording by running the program on achain.datsaved with the original classes: a new field inBlockand a new method inTransactionprintLoaded chain.dat., while bumpingserialVersionUIDinBlockor changing a field type printsCouldn't read chain.dat (InvalidClassException), so a new chain was started.mvn teststill passes (18 tests).