Repository navigation
Conversation
Contributor
Package Changes Through 170e2e8There are 4 changes which include http with patch, http-js with patch, opener with patch, opener-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_sendputs each response in the webview's resource table until its body is read to EOF or cancelled. For null-body statuses, the JS wrapper createsResponse(null)without a stream, so neither path runs. Evenawait response.arrayBuffer()only reads the empty JS body and leaves the Rust response in the table.This awaits the existing
dropBody()when no stream is created, releasing the native response before returning it to the caller. It addresses the null-body case in #3752, following @ocavue's report and analysis. Unread responses with non-empty bodies and the WebKit collection issue described there remain outside this change.The regression tests cover 204, 205 and 304, both without reading and after
arrayBuffer(). The example app exposes its webview's resource names so the tests can check the actual Rust table rather than just the JS response. Each of the six cases retained one response before the change; after it, all 16 HTTP e2e tests pass on Windows with WebView2 156.0.4314.50. Both runs used a different local fixture port because the default port was occupied; that override is not included in the PR.cargo test -p tauri-plugin-http --lib --lockedpasses all 19 tests. Strict Clippy passes for the HTTP plugin and the example app with automation enabled. The workspace JS build, ESLint, TypeScript, Prettier, rustfmt and change-file checks pass. Other platforms have not been run locally.