Repository navigation
feat(shell) raw-encoded pipe reader directly outputs buffer (no newline scan) - #1231
Merged
Merged
Conversation
GCRev
changed the title
GCRev
changed the title
GCRev
changed the title
amrbashir
requested changes
Apr 30, 2024
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
Thanks for your contributions and sorry for the late response.
Could you also add a change file in .changes directory?
Contributor
Author
|
Let me know if I did the |
amrbashir
previously approved these changes
May 2, 2024
amrbashir
approved these changes
May 2, 2024
Member
|
Thank you |
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the things that I've had to change in both the previous v1 shell and again in the v2 shell plugin is the way that the pipe reader handles output from a process. I'm working with a process that outputs binary, so breaking at the newline character disrupts the binary output. I think others have also encountered this.
I'm new to rust, but this seems like a somewhat reasonable approach that would preserve the original line-based behavior but present "raw" streams without changing anything between the process and the front end. This is, technically, a breaking change, but I propose that this is worth it going forward for the v2 release.