fix: use importlib.import_module instead of __import__ - #745
Merged
Conversation
Eijebong
approved these changes
Aug 14, 2025
bhearsum
force-pushed
the
push-xkwxslkvomvz
branch
from
August 14, 2025 16:37
41ef39b to
1d1eb85
Compare
bhearsum
force-pushed
the
push-xkwxslkvomvz
branch
from
September 2, 2025 16:36
1d1eb85 to
87835fc
Compare
Contributor
Author
|
The first version of this PR added a |
bhearsum
force-pushed
the
push-xkwxslkvomvz
branch
2 times, most recently
from
September 2, 2025 16:53
5501c7b to
42f2030
Compare
Contributor
Author
|
@Eijebong - this has changed sufficiently enough that you probably ought to have another look at it. |
bhearsum
requested review from
Eijebong
and removed request for
abhishekmadan30
September 2, 2025 16:58
Eijebong
approved these changes
Sep 3, 2025
`import_module` is newer, and provides a couple of advantages over a bare `__import__`: > The import_module() function acts as a simplifying wrapper around importlib.__import__(). This means all semantics of the function are derived from importlib.__import__(). The most important difference between these two functions is that import_module() returns the specified package or module (e.g. pkg.mod), while __import__() returns the top-level package or module (e.g. pkg). It's unclear if this will actually fix any problems in the real world, but there's no recent to use `__import__` at this point AFAICT.
bhearsum
force-pushed
the
push-xkwxslkvomvz
branch
from
September 3, 2025 15:10
42f2030 to
7939f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import_moduleis newer, and provides a couple of advantages over a bare__import__:It's unclear if this will actually fix any problems in the real world, but there's no recent to use
__import__at this point AFAICT.