fix: race condition in parallel kind processing - #744
Merged
Merged
Conversation
This race condition happens because `all_tasks` is updated in a callback, which runs asynchronously, but `kinds` and `edges` are updated in the main loop. This leads to a potential mismatch when the logic at the start of `submit_ready_kinds` runs: if `all_tasks` is updated but the other two are not, the data we feed into `load_tasks` will be incorrect.
Eijebong
approved these changes
Aug 14, 2025
Eijebong
left a comment
Eijebong
left a comment
Contributor
There was a problem hiding this comment.
Something something "must be this tall to write multithreaded code"
Contributor
Author
Clearly I am too short!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This race condition happens because
all_tasksis updated in a callback, which runs asynchronously, butkindsandedgesare updated in the main loop. This leads to a potential mismatch when the logic at the start ofsubmit_ready_kindsruns: ifall_tasksis updated but the other two are not, the data we feed intoload_taskswill be incorrect.