fix: replaced taskcluster rest api calls with package - #741
Conversation
ec75ed6 to
40c0435
Compare
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
This is shaping up nicely, thanks!
I have some changes to request. Once you put up a new revision I'll pull this down locally and see if it causes any differences in the graph (both here and in Gecko).
40c0435 to
80451af
Compare
This reverts commit cfb77a0.
|
Thanks! I'll take a closer look at this tomorrow. I'll try and test it against |
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thanks, I tested this patch both in Taskgraph and the Gecko repo and it looks like it's working as expected!
But get_retry_post_session, _do_request and _handle_artifact are all unused now in taskcluster.py. Can you remove these and associated tests please?
|
Also I think I changed my mind about leaving We can do a major version bump for this.. no big deal. |
826551a to
2e7e853
Compare
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thank you!
This is mostly cleanup, but there are two issues I neglected to catch in my first review:
- The
_handle_artifactfor yaml - The
.capitalize()issue
| continue | ||
|
|
||
| raise e | ||
| continue |
There was a problem hiding this comment.
Are you sure the taskcluster client would return None on a 404? I would have thought it would raise an exception still.. Though it would probably be from aiohttp rather than requests.
There was a problem hiding this comment.
(I assume you verified this? It's important to preserve the 404 behaviour here)
ahal
added
the
BREAKING CHANGE
8b37e80 to
549adac
Compare
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay + additional iteration. Getting close :)
| except HTTPError as e: | ||
| if e.response.status_code != 404: | ||
| raise | ||
| else: |
There was a problem hiding this comment.
I might be wrong, but I think if public/label-to-taskid.json is a 404 then it would raise an exception rather than return None. So this else clause is probably dead code.
There was a problem hiding this comment.
Did these type failures start happening as a result of your changes? Or do you get these errors even on main? If the latter, I wonder if there's something you need to do locally to get the type checker working
There was a problem hiding this comment.
These happened because of my change because currently task_def could be a json or a responce if it fails
| except requests.HTTPError as e: | ||
| task_def = get_task_definition(task_id) | ||
| except Exception as e: | ||
| raise e |
There was a problem hiding this comment.
Re-raising the exception without doing anything is the same as not catching it in the first place. So you might as well remove the try/except block.
| continue | ||
|
|
||
| raise e | ||
| continue |
There was a problem hiding this comment.
(I assume you verified this? It's important to preserve the 404 behaviour here)
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thank you, lgtm!
I think schema change is close enough to landing that maybe we should land this and that at roughly the same time so we can avoid requiring two separate major version bumps.
Regression from taskcluster#741
Regression from taskcluster#741
Regression from taskcluster#741
Regression from taskcluster#741
2 participants
fixes #221 . Created a bunch of helpers to use this package in taskcluster.py . I also didnt completely depcreate the url creation as that is still used. I bypassed it and replaced all uses when to get request is made.