Repository navigation
fix: headless login URL + friendly next/show with no attempt - #12
Open
tangentstorm wants to merge 1 commit into
Open
tangentstorm wants to merge 1 commit into
tangentstorm wants to merge 1 commit into
Conversation
Headless machines cannot open a browser, so always print the /auth/login?pre=... URL from `tanco login`. Also stop IndexError crashes from `tanco next`/`tanco show` when there is no active attempt, and add unit tests for both paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tanco loginnow always prints the OAuth URL (/auth/login?pre=...) so headless/remote users can open it manually; still trieswebbrowser.open.tanco next(andtanco show) no longer raiseIndexErrorwhen there is no active attempt; print a friendly message to runtanco initfirst.send/spawndocstrings sotancohelp lists them cleanly.Branched from
main(PR #11 still open with unrelated Firebase redirect fix).Test plan
python -m unittest tests.test_basic -vtanco loginprints a usable URL.tanco/ no attempt:tanco nextprints friendly message (no traceback)