Skip to content

build: Rust 1.99.1 everywhere - #3268

Open
jyviko wants to merge 1 commit into
mainfrom
rust-1.99.1
Open

jyviko wants to merge 1 commit into
mainfrom
rust-1.99.1

Conversation

@jyviko

@jyviko jyviko commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Pins Rust 1.99.1 (2026-10-15) in place of 1.98.0 in rust-toolchain.toml (the workflows install whatever it names), the same version as FieldCraft and SolidCraft. Historical measurement records under plan/ keep the version they were measured with.

No local build (owner's call): CI checks the toolchain change.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the pinned Rust toolchain version from 1.98.0 to 1.99.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pinned Rust toolchain channel changes from 1.98.0 to 1.99.1. The comment about pinning the toolchain remains.

Changes: Toolchain update

Layer / File(s) Summary
Update pinned toolchain
rust-toolchain.toml
The pinned Rust toolchain channel changes from 1.98.0 to 1.99.1. The existing comment about pinning remains.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: bherbruck

Merge Risk: Minimal · up to 3172e

This updates the pinned Rust toolchain to 1.99.1. No concrete problem was identified, so ordinary CI validation is enough before merging.

Architecture risk: Low · up to 3172e

The change affects 1 system.

Changed systems: rust-toolchain.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — rust-toolchain.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in rust-toolchain.toml: The pinned toolchain channel changes from 1.98.0 to 1.99.1.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "build: Rust 1.99.1 everywhere" matches the one functional change in the PR, which pins the Rust toolchain in rust-toolchain.toml from 1.98.0 to 1.99.1. The word "everywhere" is slightly bro…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "build: Rust 1.99.1 everywhere" matches the one functional change in the PR, which pins the Rust toolchain in rust-toolchain.toml from 1.98.0 to 1.99.1. The word "everywhere" is slightly broader than the single-file change, since the summary shows only rust-toolchain.toml was modified, but the title still names the main change accurately.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 04002c8 and 3172ecc.

Files selected for processing: 1

  • rust-toolchain.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant