[Benchmark, reference only] Robolectric vs Compose Desktop preview screenshot tests - #903
Closed
takahirom wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing as intended: this is a reference-only benchmark (setup + results + reproduction steps), not for merging. See the PR description for the numbers. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe sample now contains 30 benchmark Compose previews and supports generating and benchmarking preview screenshot tests through both Robolectric and Compose Desktop/JVM targets. ChangesMultiplatform preview benchmarks
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Gradle
participant PreviewGenerator
participant BenchmarkPreviews
participant ScreenshotTasks
Gradle->>PreviewGenerator: enable Robolectric and Desktop preview generation
PreviewGenerator->>BenchmarkPreviews: scan numbered `@Preview` composables
PreviewGenerator->>ScreenshotTasks: generate recording tests
ScreenshotTasks->>BenchmarkPreviews: render preview content
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reference benchmark setup and results comparing the Robolectric preview tests (latest beta) against the new Compose Desktop preview tests, on 30 identical
commonMainpreviews insample-generate-preview-tests-multiplatform(both generators enabled withseparateOutputDirs, Robolectric forced to 4.17-beta-2).This PR is intentionally closed without merging — it exists so the numbers and setup are reproducible when we need comparison evidence (docs, release notes, discussions).
Results
gradle-profiler 0.24.0, 2 warm-ups + 6 measured iterations each, warm daemon, configuration cache on,
pixelCopyRenderMode=hardware, defaultsdk=[33]/ Pixel4a qualifiers, Apple Silicon macOS:→ ~3.8x faster end-to-end for 30 previews; the per-preview steady state is ~6x, so the gap widens as suites grow.
Output fidelity notes
Both sides wrap to preview content (no window-sized captures). The images are not cross-comparable:
ComposeUiTestdefault) — exactly 2.75x height differencePer-platform goldens (via
separateOutputDirs) are the intended workflow. The density gap could be closed later by applying preview parameters to the desktop capture (proposals/02 future work).Reproduce
Summary by CodeRabbit
New Features
Tests