Skip to content

ci: typecheck the root script/ directory #47

Closed

Description

@brentyates-swx

Nothing in CI typechecks script/*.ts. bun typecheck runs turbo typecheck over workspace packages, and script/ is not one; the root tsconfig.json has no Bun types, so tsc -p tsconfig.json cannot check it either (every Bun/process/bun:test reference is an error).

That matters because script/ holds the fork's CI guards (check-workflow-guards.ts, github/same-repo-guard.ts, ...) and now sync-upstream.ts (#46). A type error there only surfaces at runtime.

Found while landing #46, where the new files were checked by hand with a throwaway tsconfig (extends ./tsconfig.json, types: ["bun"], typeRoots pointed at a package's @types). That check found three real noUncheckedIndexedAccess errors that tests did not.

Suggested fix: a script/tsconfig.json with Bun types plus a typecheck step for it (either a small workspace package or a step in typecheck.yml), then fix whatever the existing scripts fail on. Note typecheck.yml::typecheck is digest-pinned in check-workflow-guards.ts, so that digest needs a deliberate update.

Refs #46

Activity

  1. added 2 commits that reference this issue on Sep 25, 2026
    df4c304
    e58de9c
  2. added a commit that references this issue on Sep 26, 2026
    0de3445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions