Make LspTextCommand inherit from sublime_aio.ViewCommand - #3004
Draft
rwols wants to merge 1 commit into
Draft
Conversation
Member
|
I was thinking about whether we could make a command wrapper that would allow to report back a result when (asynchronically) running a command. Then we could use that in a way like result = await run_command(view, 'lsp_some_command', {})instead of the regular ST API call (which always returns view.run_command('lsp_some_command', {})This could be useful for example when applying TextEdits or a WorkspaceEdit (e.g. LspApplyWorkspaceEditCommand), where it would be nice to know whether an operation failed, or to get back the number of applied edits and edited files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes LspTextCommand inherit from sublime_aio.ViewCommand. The benefit is that this ViewCommand has special handling for
async def run()methods. So, you can write directly such a method, without having to use the somewhat cumbersome pattern of defining anasync def _run()method and invoking that one, viarun_coroutine, in the regularrun()method. So:However, I see TypeErrors being thrown for old LspTextCommand-derived classes that don't have an async
run()method. This PR is blocked on that: packagecontrol/sublime_aio#34