Skip to content

Refactor Output classes method names - #1987

Merged
kursatyurt merged 3 commits into
developfrom
refactor_output_methods
Mar 27, 2023
Merged

Refactor Output classes method names#1987
kursatyurt merged 3 commits into
developfrom
refactor_output_methods

Conversation

@kursatyurt

@kursatyurt kursatyurt commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Proposed Changes

To satisfy the code standard in SU2. Refactorization of method names in Output family class methods to CamelCase.

Will follow up with other class families.

Depends on #1985, can be merged after

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Check warning

Code scanning / CodeQL

Poorly documented large function

Poorly documented function: fewer than 2% comments for a function of 252 lines.

Check warning

Code scanning / CodeQL

Poorly documented large function

Poorly documented function: fewer than 2% comments for a function of 1853 lines.

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@kursatyurt
kursatyurt merged commit 4ed142f into develop Mar 27, 2023
@kursatyurt
kursatyurt deleted the refactor_output_methods branch March 27, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants