Skip to content

feat: bind review outcomes to frozen packages - #9

Merged
streamentry merged 1 commit into
mainfrom
agent/oamp-loop-20260724-review-bundle
Jul 23, 2026
Merged

streamentry merged 1 commit into
mainfrom
agent/oamp-loop-20260724-review-bundle

Conversation

@streamentry

Copy link
Copy Markdown
Owner

Change

Add opt-in SHA-256 binding between a DomainReviewOutcome and the exact frozen PilotEvidencePackage JSON. The CLI now accepts --package-json and fails closed on missing, malformed, mismatched, or non-object package identity input; legacy ID-only validation remains available.

Why

A reusable pep_id alone cannot show that a reviewer outcome refers to the exact package revision later associated with it. This removes that package-revision ambiguity at the external-review boundary.

Evidence

  • 135 focused tests passed.
  • Full pytest graph collected: 12,362 tests.
  • make agent-check passed: 560 docs, 0 broken links; 108 existing advisory claim findings remain.
  • make doctor passed 8/8.
  • Focused Ruff and git diff --check passed.
  • Adversarial non-object package input returned exit 1 with invalid_package.

Safety impact

No biological, safety, release, benchmark-threshold, or calibration-policy change. This is a dry-lab review-integrity control.

Proof level

No proof level is raised. A verified hash proves package identity only.

Limitations

The hash does not authenticate the reviewer, establish reviewer independence, validate the science, or establish biological activity. The legacy hook interpreter lacks existing yaml and jsonschema, so publication used ECC_SKIP_PREPUSH=1 after active-interpreter verification.

Human review needed

Yes. External-review workflow changes require qualified human review; this PR is intentionally limited to package identity binding and documentation.

@streamentry streamentry left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEAR / no blocking findings from the scoped review. The package-aware path fails closed when package identity is missing, malformed, mismatched, or non-object; legacy ID-only validation remains intact. Focused tests, full collection, agent-check, doctor, diff checks, and adversarial input evidence are recorded in the PR. Limitation acknowledged: hash equality binds package bytes only and does not authenticate the reviewer or establish biological validity. This comment is not an independent scientific approval.

@streamentry
streamentry merged commit 7de2ea4 into main Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant