Repository navigation
feat: bind review outcomes to frozen packages - #9
Merged
Merged
Conversation
streamentry
commented
Jul 23, 2026
streamentry
left a comment
Owner
Author
There was a problem hiding this comment.
CLEAR / no blocking findings from the scoped review. The package-aware path fails closed when package identity is missing, malformed, mismatched, or non-object; legacy ID-only validation remains intact. Focused tests, full collection, agent-check, doctor, diff checks, and adversarial input evidence are recorded in the PR. Limitation acknowledged: hash equality binds package bytes only and does not authenticate the reviewer or establish biological validity. This comment is not an independent scientific approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add opt-in SHA-256 binding between a DomainReviewOutcome and the exact frozen PilotEvidencePackage JSON. The CLI now accepts --package-json and fails closed on missing, malformed, mismatched, or non-object package identity input; legacy ID-only validation remains available.
Why
A reusable pep_id alone cannot show that a reviewer outcome refers to the exact package revision later associated with it. This removes that package-revision ambiguity at the external-review boundary.
Evidence
Safety impact
No biological, safety, release, benchmark-threshold, or calibration-policy change. This is a dry-lab review-integrity control.
Proof level
No proof level is raised. A verified hash proves package identity only.
Limitations
The hash does not authenticate the reviewer, establish reviewer independence, validate the science, or establish biological activity. The legacy hook interpreter lacks existing yaml and jsonschema, so publication used ECC_SKIP_PREPUSH=1 after active-interpreter verification.
Human review needed
Yes. External-review workflow changes require qualified human review; this PR is intentionally limited to package identity binding and documentation.