Repository navigation
Docs: Japanese messages are listed as partial, with the untranslated report's count - #7684
Merged
Merged
Conversation
The Japanese row in docs/localization-parity.md said every message is translated, and the Japanese catalog line in docs/target-app-parity.md said 38 messages were missing, one of them waiting on storytold#7214, which has merged. On main the untranslated report lists 98 messages without a Japanese row, 77 of which every complete-message language lacks. Both lines now give the counted rows and the report's count, and name the open pull requests that translate part of them.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follow-up to #7314. The Japanese row in
docs/localization-parity.mdsays every status and error message is translated, and the Japanese catalog line indocs/target-app-parity.mdsays 38 messages are missing, one of them waiting on #7214, which has merged.On
mainat9ddbf25bef,untranslated_reportlists 98 messages with no Japanese row: 77 that every complete-message language lacks, and 21 more. Open #7211 translates 34 of them and open #7116 translates one.This changes the two lines:
@msgand 49@msgplural) and the report's count, as the Vietnamese row does.How it was tested
Documentation only; no build step or test reads these files.
cargo test -p vectorcraft-ui-egui --lib i18n::tests::untranslated_report -- --exact --nocaptureonmainat9ddbf25bef: 1 passed. Thejasection lists 21 messages and the "every language" section lists 77 messages for all 24 complete-message languages.grep -concrates/ui-egui/src/i18n/ja.tsv: 3,562@msgrows and 49@msgpluralrows.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.