Repository navigation
i18n: Swedish translates 114 more status and error messages - #7538
Merged
bflatastic merged 2 commits intoNov 14, 2026
Merged
Conversation
The untranslated report listed these messages as missing from the Swedish catalog. Among them are the image export encoders and size limits, color profiles, color books, swatch exchange files, DXF import, 3D and Revolve errors, and the `index` check of document.activate. Each now has an @msg row in sv.tsv, with its placeholders, backticked names, format names and values kept as the English writes them. Messages that open pull requests already translate into Swedish are left to them. The Swedish row in docs/localization-parity.md is recounted, and docs/target-app-parity.md gets a line for the Swedish catalog.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The untranslated report (
untranslated_reportincrates/ui-egui/src/i18n/tests.rs) lists the status and error messages that the Swedish catalog has no@msgrow for. With Swedish selected, these messages are shown in English.crates/ui-egui/src/i18n/sv.tsvgets one commented block at its end with 114@msgrows. Among them are the image export encoders and their size limits, color profiles, color books, swatch exchange files, DXF import, the 3D and Revolve errors, theindexcheck ofdocument.activate, path combine errors, zip and script file errors, and parameter checks.smallThumbandlargeListstay exactly as the English writes them. The rows use the catalog's existing terms (färgrutebibliotek, filer för färgruteutbyte, Rotera runt axel, Skuggor, åtgärdsuppsättning, Spara för webben).`answers[{i}]` {e}has one in open i18n: script.run answers errors are translated in every complete-message catalog #7532, so this pull request leaves them out.docs/localization-parity.md's Swedish row is recounted (8,991 rows, 3,106@msg, 48@msgplural; the report lists 518 Swedish messages), anddocs/target-app-parity.mdhas one line for the Swedish catalog next to the German and Korean ones.The English messages and the commands that report them do not change.
How it was tested
No new test: a missing catalog row fails no test. The report is the evidence: on
mainatedb228ac334it lists 632 Swedish messages, and with this change it lists 518 (464 in the report's Swedish section, which some other catalog translates, one of them in open #7532, and 54 that no catalog translates yet, 53 of them in open #7211, #7378 and #7370). The existing row tests check the new rows:bundled_catalogs_are_consistent(syntax, unique rows, placeholder sets) and the tests that keep backticked names, quoted values, bare literals, keys and command ids.Focused checks on the final tree, on
mainatedb228ac334:cargo fmt --all -- --checkcargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningscargo check --workspace --testscargo test -p vectorcraft-ui-egui --lib i18n -- --include-ignored: 118 passed, 1 failed. The failure,translated_messages_keep_the_field_names_and_values_their_english_lists, is onmainatedb228ac334without this change: 2fr.tsvrows translate the field names in[subpath, anchor], and open Type: Tsume narrows the space around each character's ink #7507 fixes them. This pull request does not touchfr.tsv.cargo xtask brands,layers(30 crates) andassets(337 files)cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.