Repository navigation
Automation: replies hide a file or missing folder on the way to the recovery folder - #7461
Merged
bflatastic merged 3 commits intoNov 14, 2026
Merged
Conversation
…ecovery folder When a recovery copy fails because a folder on the way to the recovery folder is a file or is missing, the error names that folder, not the recovery folder. Replies to a client confined to read roots hid only the recovery folder itself, so the full path of that ancestor stayed visible. A reply now also hides each ancestor of a recovery folder that it writes as a whole path. The check compares text only and does not look anything up on disk. Follows storytold#7287.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follows #7287.
When a recovery copy fails because a folder on the way to the recovery folder is a file or is missing, the error names that folder (
<parent> is not a folder,couldn't make <parent>), not the recovery folder. Replies to an automation client confined to read roots hid only the recovery folder itself, so the full path of that ancestor stayed visible.hide_in_replynow also hides each ancestor of a recovery folder in use or named by a failure, when the reply writes that ancestor as a whole path, with no path text before or after it. The check (writes_whole_path) compares the reply's text only and does not look anything up on disk, so it never touches a path the client cannot read, such as a network share.How it was tested
control::tests::a_file_on_the_way_to_a_recovery_folder_outside_the_read_root_is_hidden_in_the_status: a file and a missing folder on the way to the recovery folder are shown by their names; a path that only begins or only ends with one of them stays. It fails without the change.cargo test -p vectorcraft-ui-egui: 4,561 passed, 2 ignored in the lib tests, plus 27 in the integration test binaries.cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings: clean.cargo fmt --all -- --check: clean for the changed files (crates/svg/src/lib.rsalready fails the check onmain).Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.