Repository navigation
Learn: the tabs, skill and tutorial rows and Back run commands - #7450
Merged
Merged
Conversation
The For you and Skills tab buttons, a skill's row, a tutorial's row and
Back changed the Learn panel's view directly, so the control channel and
MCP could not choose a tab, open a skill's tutorials or go back.
- learn.tab {tab: forYou|skills} shows the panel on that tab; the Skills
tab keeps the skill and tutorial it had open.
- learn.skill {skill} shows the panel on the Skills tab with that skill's
tutorials and returns the skill as learn.list lists it.
- learn.back {} goes up one level, as Back does.
- A tutorial's row runs learn.show.
- The commands are listed in both UI command catalogs, and their labels
have a row in every catalog.
- Docs: docs/mcp.md, docs/target-app-parity.md, docs/ui-parity.md.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
A click on the For you or Skills tab the panel already shows ran learn.tab although the view did not change. The tab buttons now run it only for the other tab.
The Gujarati catalog lists every menu and command label, and it had no rows for Show Learn Tab, Show Skill and Back One Level. It now has them. docs/mcp.md said the For you and Skills tab buttons run learn.tab. A tab button runs it only when the panel shows the other tab, and the page now says so.
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
On the Learn panel, the For you and Skills tab buttons, a skill's row, a tutorial's row and Back changed the view directly, so the control channel and MCP could not choose a tab, open a skill's tutorials or go back. Each control now runs a command:
learn.tab {tab: forYou|skills}shows the panel on that tab. The Skills tab keeps the skill and tutorial it had open, as clicking the tab does. It returns{tab, skill, tutorial}. A tab button runs it when the panel shows the other tab; a click on the tab the panel already shows runs no command.learn.skill {skill}shows the panel on the Skills tab with that skill's tutorials, and returns the skill aslearn.listlists it.learn.back {}goes up one level, from a tutorial's steps to its skill's tutorials and from a skill's tutorials to the list of skills. On the list of skills or the For you tab the view stays as it is.learn.show.A missing, non-string or unknown
taborskillis an error and changes nothing. The new commands are in both UI command catalogs, their labels have a row in every catalog, and their errors reuse messages that every catalog already translates.docs/mcp.mddescribes them, and the Learn lines indocs/target-app-parity.mdanddocs/ui-parity.mdname them.How it was tested
New tests in
crates/ui-egui/src/panels/learn/tests.rs, each shown failing with the three commands removed from the dispatch:the_tabs_rows_and_back_run_their_commands: clicks each tab, a skill row, a tutorial row and Back with the panel hidden, and checks the view and that the panel shows, as the command does.learn_tab_skill_and_back_move_the_viewlearn_tab_and_learn_skill_reject_a_missing_or_unknown_valuea_click_on_the_shown_tab_runs_no_commandclicks each tab twice and checks that the second click runs no command.Commands run on
dac3fe54d(withmainat676f0524cmerged in):cargo fmt --all -- --check: clean.cargo clippy -p vectorcraft-ui-egui -p vectorcraft-mcp --all-targets -- -D warnings: clean.cargo test -p vectorcraft-ui-egui --lib -- panels::learn i18n:: control:: menus::: 256 passed.cargo test -p vectorcraft-mcp: 191 passed.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.