[dotCooCoo]

What and why

The Turkish catalog (crates/ui-egui/src/i18n/tr.tsv) translated Draw as "Beraberlik", which means a tied game. The label is the toolbar's Draw category (crates/ui-egui/src/toolbar.rs:47, the group that holds Pencil, Paintbrush and Pen) and, as Draw:, the Points/Lines row of the freeform gradient (crates/ui-egui/src/panels/gradient.rs:157 and :527).

• Draw now reads "Çiz" and Draw: reads "Çiz:", the verb the catalog already uses for Draw Behind (Arkaya Çiz), Draw Inside (İçini Çiz) and Draw Normal (Normal Çiz).
• The Turkish "unknown control" message listed the accepted names as "colouring,drawMode". It now lists "coloring, drawMode", the names the command accepts, as the English row and the sibling Turkish message do.
• The hint under the Dimension dialog's scale field (crates/ui-egui/src/dialogs/dimension.rs:154) read "labels" as a noun and garbled the sentence. It now says that 1:10 labels 1 unit on the page as 10.
• The scale error Scale must be drawing:real, for example 1:10 split "çizim:gerçek" around the verb. It now keeps "çizim:gerçek" as one form.

The other Turkish rows whose English holds draw, drawn, drawing or drawer already use the right sense (Drawer menu is "Çekmece menüsü", the furniture sense) and are unchanged. Only Turkish text changes; no other language and no behavior changes.

How it was tested

New test i18n::tests::turkish_draw_labels_use_the_drawing_verb (crates/ui-egui/src/i18n/tests.rs): Draw and Draw: translate to "Çiz" and "Çiz:", no Turkish row contains "beraber", the unknown-control message lists coloring, drawMode, and the two scale rows read as fixed. It fails without the change, on each of the four fixes.

The branch is one commit on main at 1e4e3534f5, which was the current main when this was opened. Focused checks on the final tree, on main at 1e4e3534f5:

• cargo test -p vectorcraft-ui-egui --lib i18n: 116 passed, 0 failed.
• cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings and cargo check --workspace --tests pass.
• cargo xtask brands, cargo xtask layers (30 crates) and cargo xtask assets (337 files) pass.
• cargo fmt --all -- --check reports only crates/svg/src/lib.rs:491, which this pull request does not touch and which main at 1e4e3534f5 already has.
• cargo xtask ci runs in this pull request's CI.

Checklist

• cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
• No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
  unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
  messages. Errors are returned as Result and shown to the user
  (why and how).
• Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
• Every new asset has a row in ASSETS.md.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: storytold/vectorcraft
• Branch: main
• File: .coderabbit.yaml
• Commit: 8f8956f
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8831dc82-f547-4e43-b38c-9e7df0dd8863

Commits

Reviewing files that changed from the base of the PR and between 8f8956f and 50a0184.

Files ignored due to path filters: 1

• crates/ui-egui/src/i18n/tr.tsv is excluded by !**/*.tsv

Files selected for processing: 1

• crates/ui-egui/src/i18n/tests.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[bflatastic]

Merged, thanks @dotCooCoo! It passed its CI checks.