Repository navigation
3D: Expand as Wireframes measures later effects with the cast shadow - #7432
Merged
bflatastic merged 6 commits intoNov 14, 2026
Merged
bflatastic merged 6 commits into
bflatastic merged 6 commits into
Conversation
A geometry effect after an object's 3D effect, such as a Transform that scales or rotates about the center, measures the drawn art, cast shadow included. Expand as Wireframes measured the faces alone, so with a shadow on, the expanded edges landed away from the surfaces on the canvas. The faces are now reshaped together with the shadow the canvas draws behind them (Extrude & Bevel, Inflate, Rotate and Revolve, on an object, group or layer), and only the faces are kept.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 of 4 tasks
3 of 4 tasks
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A geometry effect after an object's 3D effect, such as a Transform that scales or rotates about the center, measures the drawn art, and that art includes the cast shadow. Expand as Wireframes measured the faces alone, so with the shadow on, the expanded edges landed away from the surfaces drawn on the canvas.
The wireframe now reshapes the faces together with the shadow the canvas draws behind them, then keeps only the faces. This covers Extrude & Bevel, Inflate, Rotate and Revolve on an object, group or layer. A 3D effect on a fill or stroke is unchanged, since its later effects apply to its surfaces on their own on the canvas too.
How it was tested
solids::wireframe::tests::a_later_transform_measures_the_faces_with_their_shadow: Extrude & Bevel and Revolve with the shadow on and a 50% Transform after them. The wireframe's bounds match the canvas surfaces after the same Transform. It fails without the fix for both effects (the edges are off by about 48 pt and 75 pt).cargo test -p vectorcraft-effectson62604c38bd: 761 passed, 2 ignored;envelope_ink1 passed.cargo clippy -p vectorcraft-effects --all-targets -- -D warningson62604c38bd: clean.cargo fmt --all -- --checkon62604c38bd: no diff.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.