Repository navigation
Place: Placement Options clip a DCS image inside its file's clipping path - #7422
Merged
bflatastic merged 4 commits intoNov 14, 2026
Merged
Conversation
…path When links.update or links.relink re-read a DCS file and Placement Options also clipped the image (Fill with Clip, or an aspect change that overflows), the placement rectangle replaced the file's clipping path, so plate art outside that path showed and printed. The file's clip group now stays around the image and the placement's clip goes in a clip group around it. The clip group holding just the file's group takes that clip, as one holding just an image does today, else a new one does, so later updates reuse the same two groups. A file that loses its clipping path leaves its group as a plain group inside the placement's clip. The same applies in symbols, graph designs, patterns and opacity masks.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 of 4 tasks
3 of 4 tasks
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
When
links.updateorlinks.relinkread a DCS file again and Placement Options also clipped the image (Fill with Clip, or an aspect change that overflows the old bounds), the placement rectangle replaced the file's clipping path. Plate art outside the file's clipping path then showed and printed.The file's clip group now stays around the image, and the placement's clip goes in a clip group around that one. The clip group holding just the file's group takes the placement's clip, as a clip group holding just an image does today; otherwise a new one is made. Later updates and relinks reuse the same two groups. A file that loses its clipping path leaves its group as a plain group inside the placement's clip, and gaining it again clips that same group. Images in symbols, graph designs, patterns and opacity masks follow the same rule.
docs/mcp.mddescribes it.Follows #6932.
How it was tested
crates/engine/src/tests/dcs.rs:placement_options_clip_a_dcs_image_inside_its_files_clipping_path(relink twice, update, then the file losing and regaining its clipping path twice, checking both clip paths and that no group is added) andplacement_options_clip_a_dcs_image_in_a_symbol_inside_its_files_clipping_path. Both fail without the change.cargo test -p vectorcraft-engine --lib tests::dcs: 35 passed.cargo test -p vectorcraft-engine --lib tests::links: 62 passed.cargo clippy -p vectorcraft-engine --all-targets -- -D warningsandcargo fmt --all -- --check: clean.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.